You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/01 18:31:57 UTC
[GitHub] [superset] prosdev0107 opened a new pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
prosdev0107 opened a new pull request #18988:
URL: https://github.com/apache/superset/pull/18988
### SUMMARY
Hide Tooltip when Column Header Isn't Truncated
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
Always display the Tooltip on the column header
AFTER:
Make that hide the Tooltip when the column isn't truncated.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18988:
URL: https://github.com/apache/superset/pull/18988#issuecomment-1055777888
# [Codecov](https://codecov.io/gh/apache/superset/pull/18988?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18988](https://codecov.io/gh/apache/superset/pull/18988?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ed4968) into [master](https://codecov.io/gh/apache/superset/commit/150fd0dfd395e7e55c4e88957be04daf7be16666?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (150fd0d) will **decrease** coverage by `0.00%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 9ed4968 differs from pull request most recent head 61e16a0. Consider uploading reports for the commit 61e16a0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18988 +/- ##
==========================================
- Coverage 66.58% 66.58% -0.01%
==========================================
Files 1641 1641
Lines 63524 63530 +6
Branches 6421 6423 +2
==========================================
+ Hits 42299 42302 +3
- Misses 19548 19550 +2
- Partials 1677 1678 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.38% <50.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/18988/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `70.71% <50.00%> (-0.72%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/18988/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `40.86% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18988?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18988?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [150fd0d...61e16a0](https://codecov.io/gh/apache/superset/pull/18988?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r828721718
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
@evans was this decided somewhere as a breakpoint?
If not, @prosdev0107 consider using [this](https://stackoverflow.com/questions/61124992/is-it-possible-to-show-an-ant-design-tooltip-conditionally-only-when-the-content) if possible, which is a dynamic way of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r829029377
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
@diegomedina248 Evan's correct handle is @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18988:
URL: https://github.com/apache/superset/pull/18988#issuecomment-1063298053
@rusackas Ephemeral environment spinning up at http://52.12.207.55:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r828721718
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
@rusackas was this decided somewhere as a breakpoint?
If not, @prosdev0107 consider using [this](https://stackoverflow.com/questions/61124992/is-it-possible-to-show-an-ant-design-tooltip-conditionally-only-when-the-content) if possible, which is a dynamic way of doing it.
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
@michael-s-molina crap 🤦 , thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r828721718
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
@rusackas was this decided somewhere as a breakpoint?
If not, @prosdev0107 consider using [this](https://stackoverflow.com/questions/61124992/is-it-possible-to-show-an-ant-design-tooltip-conditionally-only-when-the-content) if possible, which is a dynamic way of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #18988:
URL: https://github.com/apache/superset/pull/18988#issuecomment-1063362401
Testing the PR, it's not clear that the headers are ever truncated.
If I'm mistaken, please add testing steps and/or screenshots.
<img width="1096" alt="image" src="https://user-images.githubusercontent.com/812905/157534308-f18f9ea3-eba1-48a7-baad-d42ca1da8560.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r829038880
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
@michael-s-molina crap 🤦 , thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #18988:
URL: https://github.com/apache/superset/pull/18988#issuecomment-1063296663
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r829409939
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
The only downside to the AntD approach is a little more vendor lock-in, should we ever decide to change component libraries again... but it probably won't be our biggest battle then :)
The `getTextDimension` approach seems like it'd work, but is slightly fragile-looking to me as a technique to start reusing in more places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r829407858
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
THANK YOU. I spent a few minutes trying to find an example of the [AntD-native approach](https://stackoverflow.com/questions/61124992/is-it-possible-to-show-an-ant-design-tooltip-conditionally-only-when-the-content). I swear I had a CodePen example of this that I once wrote up, but I seem to have left it in my other coat.
The 200px is indeed arbitrary. It also doesn't seem to _matter_, thus my comment/screenshot above.
I'm OK with setting a reasonable maximum column width. Exactly _how_ wide is up for grabs. Maybe @kasiazjc has opinions on the matter. We should also test/consider how the _contents_ of the cell are wrapped/truncated when hitting this maximum width.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r832047184
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
Sorry for the late response, but re: columns setting max/min width can be tricky I think. To do it well we would have to go through different types of data there are in the columns and define min/max... If we would introduce max width for columns and let's say we would have 2 columns it could look weird as the table would not be stretched from left or right.
Easy solution would be to scale the column width, so depending on the width of the table all columns always have the same width 🤔 but still, lot's of edge case.
That is, if I understand the problem correctly 🙃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r829029377
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
@diegomedina248 Evan's correct handle is @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r829407858
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
THANK YOU. I spent a few minutes trying to find an example of the [AntD-native approach](https://stackoverflow.com/questions/61124992/is-it-possible-to-show-an-ant-design-tooltip-conditionally-only-when-the-content). I swear I had a CodePen example of this that I once wrote up, but I seem to have left it in my other coat.
The 200px is indeed arbitrary. It also doesn't seem to _matter_, thus my comment/screenshot above.
I'm OK with setting a reasonable maximum column width. Exactly _how_ wide is up for grabs. Maybe @kasiazjc has opinions on the matter. We should also test/consider how the _contents_ of the cell are wrapped/truncated when hitting this maximum width.
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;
Review comment:
The only downside to the AntD approach is a little more vendor lock-in, should we ever decide to change component libraries again... but it probably won't be our biggest battle then :)
The `getTextDimension` approach seems like it'd work, but is slightly fragile-looking to me as a technique to start reusing in more places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org