[GitHub] [doris] zhannngchen commented on a diff in pull request #19609: [feature](compaction) support delete in cumulative compaction

["zhannngchen (via GitHub)" <gi...@apache.org>]

zhannngchen commented on code in PR #19609:
URL: https://github.com/apache/doris/pull/19609#discussion_r1214438469


##########
be/test/olap/cumulative_compaction_policy_test.cpp:
##########
@@ -609,10 +609,11 @@ TEST_F(TestSizeBasedCumulativeCompactionPolicy, pick_input_rowsets_delete) {
             _tablet.get(), candidate_rowsets, 10, 5, &input_rowsets, &last_delete_version,
             &compaction_score);
 
-    EXPECT_EQ(2, input_rowsets.size());
-    EXPECT_EQ(4, compaction_score);
-    EXPECT_EQ(5, last_delete_version.first);
-    EXPECT_EQ(5, last_delete_version.second);
+    // now cumulative compaction support delete
+    EXPECT_EQ(4, input_rowsets.size());
+    EXPECT_EQ(10, compaction_score);
+    EXPECT_EQ(-1, last_delete_version.first);
+    EXPECT_EQ(-1, last_delete_version.second);

Review Comment:
   Add a test to cover such case:
   1. base [0-10]
   2. write some key in version 11, delete it in version 12, write same key in version 13
   3. make sure the key in version 13 is not deleted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org