You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/12 05:46:11 UTC
Review Request: Updated the gtest filter in Environment constructor rather
than in 'SetUp' in order to make sure the filter is properly set before
invoking RUN_ALL_TESTS.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9868/
-----------------------------------------------------------
Review request for mesos, Thomas Marshall, Vinod Kone, and Ben Mahler.
Description
-------
I like the idea of keeping the filter update code with the "environment" code, since the filter is updated based on the environment. There is also a nice guarantee that this code will get invoked before RUN_ALL_TESTS because the environment instance has to be added before RUN_ALL_TESTS is invoked.
Diffs
-----
src/tests/environment.hpp f1e61fec73f12a365ffe3baa12594ab205557300
src/tests/environment.cpp bda72ae0310e74015f3fbde50fecbf6515276e81
Diff: https://reviews.apache.org/r/9868/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Updated the gtest filter in Environment constructor
rather than in 'SetUp' in order to make sure the filter is properly set
before invoking RUN_ALL_TESTS.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9868/#review17715
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 12, 2013, 4:46 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9868/
> -----------------------------------------------------------
>
> (Updated March 12, 2013, 4:46 a.m.)
>
>
> Review request for mesos, Thomas Marshall, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> I like the idea of keeping the filter update code with the "environment" code, since the filter is updated based on the environment. There is also a nice guarantee that this code will get invoked before RUN_ALL_TESTS because the environment instance has to be added before RUN_ALL_TESTS is invoked.
>
>
> Diffs
> -----
>
> src/tests/environment.hpp f1e61fec73f12a365ffe3baa12594ab205557300
> src/tests/environment.cpp bda72ae0310e74015f3fbde50fecbf6515276e81
>
> Diff: https://reviews.apache.org/r/9868/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>