You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Dirk Balfanz (JIRA)" <ji...@apache.org> on 2008/04/08 00:59:24 UTC
[jira] Created: (SHINDIG-183) OAuth for JSON targets is broken
OAuth for JSON targets is broken
--------------------------------
Key: SHINDIG-183
URL: https://issues.apache.org/jira/browse/SHINDIG-183
Project: Shindig
Issue Type: Bug
Components: Gadgets Server - Java
Reporter: Dirk Balfanz
Attachments: patch-empty-json-response.txt
Currently, OAuth for JSON targets is broken. When a Gadget does a makeRequest with ContentType.JSON and AuthorizationType.AUTHENTICATED (i.e. OAuth), then typically the first roundtrip between shindig and the makeRequest target is an OAuth call to obtain a request token. The response text at that point will be empty. Which currently causes a "text has no properties" error when the response handler tries to parse the received JSON, and breaks the OAuth flow.
The attached patch fixes the issue by allowing JSON responses that have an empty body.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-183) OAuth for JSON targets is broken
Posted by "Dirk Balfanz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dirk Balfanz updated SHINDIG-183:
---------------------------------
Attachment: (was: patch-empty-json-response.txt)
> OAuth for JSON targets is broken
> --------------------------------
>
> Key: SHINDIG-183
> URL: https://issues.apache.org/jira/browse/SHINDIG-183
> Project: Shindig
> Issue Type: Bug
> Components: Gadgets Server - Java
> Reporter: Dirk Balfanz
> Attachments: patch-empty-json-response.txt
>
>
> Currently, OAuth for JSON targets is broken. When a Gadget does a makeRequest with ContentType.JSON and AuthorizationType.AUTHENTICATED (i.e. OAuth), then typically the first roundtrip between shindig and the makeRequest target is an OAuth call to obtain a request token. The response text at that point will be empty. Which currently causes a "text has no properties" error when the response handler tries to parse the received JSON, and breaks the OAuth flow.
> The attached patch fixes the issue by allowing JSON responses that have an empty body.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-183) OAuth for JSON targets is broken
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586621#action_12586621 ]
Brian Eaton commented on SHINDIG-183:
-------------------------------------
Erm. Hard to tell from looking at a patch file, but it looks like this will leave bad indentation in the file. Can you fix the indentation?
> OAuth for JSON targets is broken
> --------------------------------
>
> Key: SHINDIG-183
> URL: https://issues.apache.org/jira/browse/SHINDIG-183
> Project: Shindig
> Issue Type: Bug
> Components: Gadgets Server - Java
> Reporter: Dirk Balfanz
> Attachments: patch-empty-json-response.txt
>
>
> Currently, OAuth for JSON targets is broken. When a Gadget does a makeRequest with ContentType.JSON and AuthorizationType.AUTHENTICATED (i.e. OAuth), then typically the first roundtrip between shindig and the makeRequest target is an OAuth call to obtain a request token. The response text at that point will be empty. Which currently causes a "text has no properties" error when the response handler tries to parse the received JSON, and breaks the OAuth flow.
> The attached patch fixes the issue by allowing JSON responses that have an empty body.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-183) OAuth for JSON targets is broken
Posted by "Dirk Balfanz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dirk Balfanz updated SHINDIG-183:
---------------------------------
Attachment: patch-empty-json-response.txt
> OAuth for JSON targets is broken
> --------------------------------
>
> Key: SHINDIG-183
> URL: https://issues.apache.org/jira/browse/SHINDIG-183
> Project: Shindig
> Issue Type: Bug
> Components: Gadgets Server - Java
> Reporter: Dirk Balfanz
> Attachments: patch-empty-json-response.txt
>
>
> Currently, OAuth for JSON targets is broken. When a Gadget does a makeRequest with ContentType.JSON and AuthorizationType.AUTHENTICATED (i.e. OAuth), then typically the first roundtrip between shindig and the makeRequest target is an OAuth call to obtain a request token. The response text at that point will be empty. Which currently causes a "text has no properties" error when the response handler tries to parse the received JSON, and breaks the OAuth flow.
> The attached patch fixes the issue by allowing JSON responses that have an empty body.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-183) OAuth for JSON targets is broken
Posted by "Dirk Balfanz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dirk Balfanz updated SHINDIG-183:
---------------------------------
Attachment: patch-empty-json-response.txt
> OAuth for JSON targets is broken
> --------------------------------
>
> Key: SHINDIG-183
> URL: https://issues.apache.org/jira/browse/SHINDIG-183
> Project: Shindig
> Issue Type: Bug
> Components: Gadgets Server - Java
> Reporter: Dirk Balfanz
> Attachments: patch-empty-json-response.txt
>
>
> Currently, OAuth for JSON targets is broken. When a Gadget does a makeRequest with ContentType.JSON and AuthorizationType.AUTHENTICATED (i.e. OAuth), then typically the first roundtrip between shindig and the makeRequest target is an OAuth call to obtain a request token. The response text at that point will be empty. Which currently causes a "text has no properties" error when the response handler tries to parse the received JSON, and breaks the OAuth flow.
> The attached patch fixes the issue by allowing JSON responses that have an empty body.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-183) OAuth for JSON targets is broken
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-183.
-------------------------------
Resolution: Fixed
Applied in r648154. Thanks!
> OAuth for JSON targets is broken
> --------------------------------
>
> Key: SHINDIG-183
> URL: https://issues.apache.org/jira/browse/SHINDIG-183
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (Java)
> Reporter: Dirk Balfanz
> Attachments: patch-empty-json-response.txt
>
>
> Currently, OAuth for JSON targets is broken. When a Gadget does a makeRequest with ContentType.JSON and AuthorizationType.AUTHENTICATED (i.e. OAuth), then typically the first roundtrip between shindig and the makeRequest target is an OAuth call to obtain a request token. The response text at that point will be empty. Which currently causes a "text has no properties" error when the response handler tries to parse the received JSON, and breaks the OAuth flow.
> The attached patch fixes the issue by allowing JSON responses that have an empty body.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-183) OAuth for JSON targets is broken
Posted by "Dirk Balfanz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586882#action_12586882 ]
Dirk Balfanz commented on SHINDIG-183:
--------------------------------------
The attached patch now has correct indentation.
> OAuth for JSON targets is broken
> --------------------------------
>
> Key: SHINDIG-183
> URL: https://issues.apache.org/jira/browse/SHINDIG-183
> Project: Shindig
> Issue Type: Bug
> Components: Gadgets Server - Java
> Reporter: Dirk Balfanz
> Attachments: patch-empty-json-response.txt
>
>
> Currently, OAuth for JSON targets is broken. When a Gadget does a makeRequest with ContentType.JSON and AuthorizationType.AUTHENTICATED (i.e. OAuth), then typically the first roundtrip between shindig and the makeRequest target is an OAuth call to obtain a request token. The response text at that point will be empty. Which currently causes a "text has no properties" error when the response handler tries to parse the received JSON, and breaks the OAuth flow.
> The attached patch fixes the issue by allowing JSON responses that have an empty body.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.