[GitHub] [spark] HyukjinKwon commented on a change in pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #29454:
URL: https://github.com/apache/spark/pull/29454#discussion_r471888420



##########
File path: .github/workflows/master.yml
##########
@@ -183,6 +183,12 @@ jobs:
       with:
         name: test-results-${{ matrix.modules }}-${{ matrix.comment }}-${{ matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
         path: "**/target/test-reports/*.xml"
+    - name: Upload unit tests log files
+      if: failure()

Review comment:
       Zipped logfiles are ~300 MB. Jenkins always uploads but GitHub Actions uploads failed tests only for now.
   
   I can't find the clear answer of the size limit from my googling but seems like there's a limit internally. Should be best to save the resources.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org