You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/03/10 19:06:46 UTC

[jira] Created: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

LocalJobRunner gets NullPointerException if there is no output directory
------------------------------------------------------------------------

                 Key: HADOOP-2985
                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
             Project: Hadoop Core
          Issue Type: Bug
          Components: mapred
    Affects Versions: 0.16.1
            Reporter: Owen O'Malley
            Assignee: Owen O'Malley
            Priority: Critical
             Fix For: 0.16.2


The local job runner gets a null pointer, if the job doesn't have an output directory.

java.lang.NullPointerException
	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)

The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579023#action_12579023 ] 

Hadoop QA commented on HADOOP-2985:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12377871/patch-2985.txt
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1970/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1970/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1970/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1970/console

This message is automatically generated.

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>         Attachments: patch-2985.txt, patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-2985:
--------------------------------------------

    Fix Version/s: 0.17.0

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2, 0.17.0
>
>         Attachments: patch-2985.txt, patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-2985:
--------------------------------------------

    Status: Patch Available  (was: Open)

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>         Attachments: patch-2985.txt, patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-2985:
--------------------------------------------

    Attachment: patch-2985.txt

This patch addresses the following:
1. adds output path != null check for LocalJobRunner.
2. Removes ERROR logging from JobInProgress when output path is null
3. Pulled all of the string literals for "_temporary" to references to a static final string into MRConstants.

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>         Attachments: patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580329#action_12580329 ] 

Hudson commented on HADOOP-2985:
--------------------------------

Integrated in Hadoop-trunk #433 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/433/])

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>         Attachments: patch-2985.txt, patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu reassigned HADOOP-2985:
-----------------------------------------------

    Assignee: Amareshwari Sriramadasu  (was: Owen O'Malley)

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-2985:
--------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.17.0)
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Amareshwari!

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>         Attachments: patch-2985.txt, patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577378#action_12577378 ] 

Amareshwari Sriramadasu commented on HADOOP-2985:
-------------------------------------------------

bq. The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.
Owen, Could you give some more details on this? I didnt get which ERROR message you are mentioning here.

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Critical
>             Fix For: 0.16.2
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-2985:
--------------------------------------------

    Status: Open  (was: Patch Available)

Sorry. Generated a wrong patch. 

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>         Attachments: patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578533#action_12578533 ] 

Hadoop QA commented on HADOOP-2985:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12377759/patch-2985.txt
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs -1.  The patch appears to cause Findbugs to fail.

    core tests -1.  The patch failed core unit tests.

    contrib tests -1.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1957/testReport/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1957/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1957/console

This message is automatically generated.

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>         Attachments: patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-2985:
--------------------------------------------

    Status: Patch Available  (was: Open)

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>         Attachments: patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2985) LocalJobRunner gets NullPointerException if there is no output directory

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-2985:
--------------------------------------------

    Attachment: patch-2985.txt

Attaching the correct patch.

> LocalJobRunner gets NullPointerException if there is no output directory
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.1
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 0.16.2
>
>         Attachments: patch-2985.txt, patch-2985.txt
>
>
> The local job runner gets a null pointer, if the job doesn't have an output directory.
> java.lang.NullPointerException
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:61)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:50)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:117)
> The Job Tracker also gets an ERROR log message, which is incorrect and should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.