You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2024/07/02 17:07:56 UTC
[PR] [branch-2.0](function) fix nereids fold constant wrong result of abs (#37065) [doris]
zclllyybb opened a new pull request, #37107:
URL: https://github.com/apache/doris/pull/37107
## Proposed changes
Issue Number: close #xxx
before:
```sql
mysql [optest]>select abs(cast(-9223372036854775808 as BIGINT));
+-------------------------------------------+
| abs(cast(-9223372036854775808 as BIGINT)) |
+-------------------------------------------+
| -9223372036854775808 |
+-------------------------------------------+
1 row in set (0.00 sec)
```
now:
```sql
mysql [optest]>select abs(cast(-9223372036854775808 as BIGINT));
+-------------------------------------------+
| abs(cast(-9223372036854775808 as BIGINT)) |
+-------------------------------------------+
| 9223372036854775808 |
+-------------------------------------------+
1 row in set (0.01 sec)
```
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-2.0](function) fix nereids fold constant wrong result of abs (#37065) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37107:
URL: https://github.com/apache/doris/pull/37107#issuecomment-2200189708
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-2.0](function) fix nereids fold constant wrong result of abs (#37065) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #37107:
URL: https://github.com/apache/doris/pull/37107#issuecomment-2200189701
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-2.0](function) fix nereids fold constant wrong result of abs (#37065) [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #37107:
URL: https://github.com/apache/doris/pull/37107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-2.0](function) fix nereids fold constant wrong result of abs (#37065) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37107:
URL: https://github.com/apache/doris/pull/37107#issuecomment-2200235835
<details>
<summary>TPC-H: <b>Total hot run time: 49802 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1f0a58282f5e1186e84c3060bb080c6e65fe497c, data reload: false
------ Round 1 ----------------------------------
q1 18175 4425 4471 4425
q2 2038 155 154 154
q3 10451 1915 1944 1915
q4 10300 1264 1325 1264
q5 8439 3985 3837 3837
q6 239 125 125 125
q7 2038 1618 1600 1600
q8 9517 2735 2718 2718
q9 13917 10256 10205 10205
q10 8608 3512 3519 3512
q11 410 246 257 246
q12 472 311 313 311
q13 18355 3959 4048 3959
q14 358 326 325 325
q15 516 465 446 446
q16 698 578 584 578
q17 1129 964 929 929
q18 7350 6857 6769 6769
q19 1786 1695 1643 1643
q20 541 318 300 300
q21 4433 4194 4090 4090
q22 531 456 451 451
Total cold run time: 120301 ms
Total hot run time: 49802 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4346 4345 4362 4345
q2 323 229 227 227
q3 4167 4185 4148 4148
q4 2759 2743 2755 2743
q5 7121 7103 7075 7075
q6 238 119 120 119
q7 3246 2813 2787 2787
q8 4383 4480 4494 4480
q9 16875 16825 16700 16700
q10 4204 4285 4262 4262
q11 791 696 684 684
q12 1021 834 856 834
q13 6993 3763 3736 3736
q14 452 417 424 417
q15 499 448 466 448
q16 727 682 680 680
q17 3797 3834 3855 3834
q18 8771 8922 8887 8887
q19 1734 1714 1692 1692
q20 2378 2167 2102 2102
q21 8539 8694 8485 8485
q22 1027 1004 977 977
Total cold run time: 84391 ms
Total hot run time: 79662 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org