[jira] [Comment Edited] (BIGTOP-950) race condition for output consumption in Shell code

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646318#comment-13646318 ] 

Konstantin Boudnik edited comment on BIGTOP-950 at 5/1/13 2:30 AM:
-------------------------------------------------------------------

-1 - this is the regression from BIGTOP-835
Instead of fixing it with an arguably sub-optimal workaround I'd rather revert BIGTOP-835 and do it correctly.

Besides, this like in the particular code block
  if (timeout >= 0) {  
doesn't make any frigging sense. What's the point of 0 timeout???
                
      was (Author: cos):
    -1 - this is the regression from BIGTOP-835
Instead of fixing it with an arguably sub-optimal workaround I'd rather revert BIGTOP-835 and do it correctly.

Besides, this like in the particular code block
{{    if (timeout >= 0) { }} 
doesn't make any frigging sense. What's the point of 0 timeout???
                  
> race condition for output consumption in Shell code
> ---------------------------------------------------
>
>                 Key: BIGTOP-950
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-950
>             Project: Bigtop
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 0.5.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.6.0
>
>         Attachments: 0001-BIGTOP-950.-race-condition-for-output-consumption-in.patch
>
>
> It seems that there's a race condition in Shell's implementation between calling proc.waitFor() and making sure that all of the output is transferred to ByteArrays by consumeProcessOutput

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira