You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/07 23:45:08 UTC

[GitHub] [zookeeper] hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time

hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355150282
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -500,6 +501,10 @@ public void loadData() throws IOException, InterruptedException {
         takeSnapshot();
     }
 
+    public boolean compareDigest(TxnHeader header, Record txn, TxnDigest digest) {
 
 Review comment:
   Is this method needed? It's never actually called anywhere. If it's not needed, we should remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services