You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by abhishekagarwal87 <gi...@git.apache.org> on 2016/03/20 13:37:55 UTC
[GitHub] storm pull request: STORM-1622: Rename classes with older third pa...
GitHub user abhishekagarwal87 opened a pull request:
https://github.com/apache/storm/pull/1240
STORM-1622: Rename classes with older third party shaded packages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abhishekagarwal87/storm shaded-classes2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1240
----
commit 77facb534b9dbbb7a37ca528c85af047f020e121
Author: Abhishek Agarwal <ab...@inmobi.com>
Date: 2016-03-20T12:34:02Z
STORM-1622: Rename classes with older third party shaded packages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1622: Rename classes with older third pa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1622: Rename classes with older third pa...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1240#issuecomment-199994152
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1622: Rename classes with older third pa...
Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1240#issuecomment-198922168
@revans2 - This additional support need not be in master. Let me know if you want me to raise a PR for master as well. Thanks in advance for considering this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1622: Rename classes with older third pa...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1240#issuecomment-199957592
+1 looks OK to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---