[GitHub] [spark] erikerlandson edited a comment on pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

[GitBox <gi...@apache.org>]

erikerlandson edited a comment on pull request #28983:
URL: https://github.com/apache/spark/pull/28983#issuecomment-653697145


   when trying to refer to either ScalaAggregator or Aggregator over in catalyst, I'm running into some scoping problems, which are all similar to:
   ```scala
   [error] /home/eje/git/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala:27: object expressions is not a member of package org.apache.spark.sql
   ```
   I believe these are related to some scoping firewall with catalyst, for example:
   ```scala
   package org.apache.spark.sql
   
   /**
    * The physical execution component of Spark SQL. Note that this is a private package.
    * All classes in catalyst are considered an internal API to Spark SQL and are subject
    * to change between minor releases.
    */
   package object execution
   ```
   
   I tried moving ScalaAggregator over to `org.apache.spark.sql.catalyst.expressions`, but now it can't see `Aggregator`, and I can't move that without breaking backward compatibility.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org