You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/01 01:03:15 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #138: remove protobuf license
pjfanning opened a new pull request, #138:
URL: https://github.com/apache/incubator-pekko/pull/138
We've kept the Google license headers in the protobuf derived source files. We don't need to include the license file in the git base dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #138: remove protobuf license
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #138:
URL: https://github.com/apache/incubator-pekko/pull/138#issuecomment-1411298124
Thanks @justinmclean - the LICENSE gets copied into all the jars. The extra text refers to the COPYING.protobuf file. Should we start adding that to our jars too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #138: update jar build to include protobuf license
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #138:
URL: https://github.com/apache/incubator-pekko/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #138: update jar build to include protobuf license
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #138:
URL: https://github.com/apache/incubator-pekko/pull/138#issuecomment-1413588070
I raised https://github.com/apache/incubator-pekko/issues/140 for one unresolved issue with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] justinmclean commented on pull request #138: remove protobuf license
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on PR #138:
URL: https://github.com/apache/incubator-pekko/pull/138#issuecomment-1411311419
Yes - see the guiding principle (https://infra.apache.org/licensing-howto.html#guiding). In practice convenience binaries usually have a lot more stuff in them and so will have more things mentioned in LICENSE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #138: update jar build to include protobuf license
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #138:
URL: https://github.com/apache/incubator-pekko/pull/138#issuecomment-1423916336
Ugh I forgot about this, thanks for raising it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] justinmclean commented on pull request #138: remove protobuf license
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on PR #138:
URL: https://github.com/apache/incubator-pekko/pull/138#issuecomment-1411292442
HI,
It’s recommend you keep that information in LICENSE see [1]
Kind Regards,
Justin
1. https://infra.apache.org/licensing-howto.html#alv2-dep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #138: update jar build to include protobuf license
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #138:
URL: https://github.com/apache/incubator-pekko/pull/138#issuecomment-1423915101
@mdedetrich would you be able to review this - it is an ASF requirement to get the licenses correct in our jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org