[GitHub] [syncope] ilgrosso commented on a change in pull request #204: Enable Swagger support for WA

[GitBox <gi...@apache.org>]

ilgrosso commented on a change in pull request #204:
URL: https://github.com/apache/syncope/pull/204#discussion_r454906836



##########
File path: wa/starter/src/main/resources/application.properties
##########
@@ -45,3 +45,6 @@ spring.main.allow-bean-definition-overriding=true
 spring.main.lazy-initialization=false
 
 service.discovery.address=http://localhost:8080/syncope-wa/
+
+version=${syncope.version}
+buildNumber=${buildNumber}

Review comment:
       see above

##########
File path: wa/starter/src/main/java/org/apache/syncope/wa/starter/config/SyncopeWAConfiguration.java
##########
@@ -221,4 +237,14 @@ public KeymasterStart keymasterStart() {
     public KeymasterStop keymasterStop() {
         return new KeymasterStop(NetworkService.Type.WA);
     }
+
+    @Bean
+    public String version() {
+        return applicationContext.getEnvironment().getProperty("version");
+    }
+
+    @Bean
+    public String buildNumber() {

Review comment:
       This should not be needed.
   Please also consider that it would require the `buildnumber-maven-plugin` to run.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org