You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/17 18:03:58 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4698: Fix npe when migrating vm with volume
GutoVeronezi opened a new pull request #4698:
URL: https://github.com/apache/cloudstack/pull/4698
### Description
In the execution flow of the API `migrateVirtualMachineWithVolume`, there is a step that copies the volume's template to the target storage, if it is needed.
In some cases when the volume is a `data` type, it (the volume) does not have a template; therefore, it is going to generate an NPE when it tries to get the template's ID (Long to long auto conversion).
This PR intends to validate if the volume being copied has a template, before trying to copy the template.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### How Has This Been Tested?
It has been tested locally in a test lab.
1. I had created a VM and attached 2 volumes to it.
2. I had migrated the VM to another `host` and the volumes to different `storage` to see if it migrates accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4698: Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4698:
URL: https://github.com/apache/cloudstack/pull/4698#issuecomment-781054758
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4698: Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4698:
URL: https://github.com/apache/cloudstack/pull/4698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4698: Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4698:
URL: https://github.com/apache/cloudstack/pull/4698#issuecomment-781032667
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4698: Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4698:
URL: https://github.com/apache/cloudstack/pull/4698#issuecomment-781032488
@GutoVeronezi which hypervisor this NPE was seen because I didn't face it on VMware.
Also, since this is a bug fix it should go to 4.15.1
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rafaelweingartner commented on pull request #4698: Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
rafaelweingartner commented on pull request #4698:
URL: https://github.com/apache/cloudstack/pull/4698#issuecomment-781257832
@abhinandanprateek this happens on KVM.
I would like to highlight one thing here. The contributor is willing to send the changes/patch to master. We (as the ACS community) can never force the contributor to do anything he/she does not want (and that is not a technical part of the contribution). We can review the code and ask for improvement/changes; we can try to convince the contributor to send the code to an already release version, but we can not say "it is a bug fix, so send it to x.y.z" (this sounds like an order). However, as the name says, it is a contribution. Therefore, it is non-paid work dedicated to ACS that somebody is providing (unless you somehow are providing this contribution by supporting the contributor). I have seen this happening in other PRs, and as a member of the PMC I would like to highlight that this is not part of the Apache Way.
If somebody/some company in the community liked the changes and would like to see it in a specific branch, they can cherry-pick/back-port from master to the version branch they want.
Please, it is nothing personal or anything. It is just something I noticed, and that we (as a community) should pay attention to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org