[GitHub] [camel-k] lburgazzoli commented on a change in pull request #2766: gosec

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #2766:
URL: https://github.com/apache/camel-k/pull/2766#discussion_r755737923



##########
File path: .golangci.yml
##########
@@ -18,54 +18,46 @@
 linters-settings:
   lll:
     line-length: 170
+  goconst:
+    ignore-tests: true
 linters:
-  disable-all: true
-  enable:
-    - asciicheck
-    - bodyclose
-    - deadcode
-    - depguard
-    - dogsled
-    - durationcheck
-    - errcheck
-    - errname
-    - errorlint
-    - exportloopref
-    - forcetypeassert
-    - gocritic
-    - gofmt
+  enable-all: true

Review comment:
       I can revert to the `disable-all` mode, I don't have any strong opinion here.
   
   The reason I did it the other way is to be sure we are not missing any important lint (as example. the `gosec` one was missing) so I did try to run it with all the possible lints and then disabling those that are just noise.
   
   @astefanutti  @squakez @tadayosi since I'm not contributing to the project very often now, I let you decide




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org