You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dancollins34 <gi...@git.apache.org> on 2018/02/03 22:25:49 UTC
[GitHub] tinkerpop pull request #796: Added correct setting of future exceptions, pur...
GitHub user dancollins34 opened a pull request:
https://github.com/apache/tinkerpop/pull/796
Added correct setting of future exceptions, pursuant to TINKERPOP-1883
https://issues.apache.org/jira/browse/TINKERPOP-1883
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dancollins34/tinkerpop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/796.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #796
----
commit 2257d951ebc11de3b3bd13c93417c970c3d5c182
Author: dancollins34 <da...@...>
Date: 2018-02-03T22:24:44Z
Added correct setting of future exceptions, pursuant to TINKERPOP-1883
https://issues.apache.org/jira/browse/TINKERPOP-1883
----
---
[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/796
sweet
---
[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/796
i think we can just CTR this in - it's pretty simple. i'll just cherry pick to tp32 and merge from there, then manually close this
---
[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/796
LGTM
VOTE +1
---
[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/796
@dancollins34 sorry it took me a while to take a look at this - thanks for submitting it. is this also a problem on 3.2.x? if so, this pull request should be re-targeted at the tp32 branch.
---
[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/796
@davebshow this should target tp32 is that correct?
---
[GitHub] tinkerpop pull request #796: Added correct setting of future exceptions, pur...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/796
---
[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/796
Yes this affects both 32 and master
---