You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/04/08 10:39:40 UTC
[GitHub] [cassandra] nastra opened a new pull request #527: CASSANDRA-15707:
Fix cqlsh output test
nastra opened a new pull request #527: CASSANDRA-15707: Fix cqlsh output test
URL: https://github.com/apache/cassandra/pull/527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] nastra commented on a change in pull request #527:
CASSANDRA-15707: Fix cqlsh output test
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #527: CASSANDRA-15707: Fix cqlsh output test
URL: https://github.com/apache/cassandra/pull/527#discussion_r405508253
##########
File path: CHANGES.txt
##########
@@ -1,4 +1,5 @@
4.0-alpha4
+ * Fix cqlsh output test (CASSANDRA-15707)
Review comment:
makes perfect sense to mention only user-relevant things in CHANGES.txt, so I removed my changes there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] nastra commented on a change in pull request #527:
CASSANDRA-15707: Fix cqlsh output test
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #527: CASSANDRA-15707: Fix cqlsh output test
URL: https://github.com/apache/cassandra/pull/527#discussion_r405456766
##########
File path: CHANGES.txt
##########
@@ -1,4 +1,5 @@
4.0-alpha4
+ * Fix cqlsh output test (CASSANDRA-15707)
Review comment:
not sure either...I can remove those as they cause merge conflicts all the time ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request
#527: CASSANDRA-15707: Fix cqlsh output test
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #527: CASSANDRA-15707: Fix cqlsh output test
URL: https://github.com/apache/cassandra/pull/527#discussion_r405439570
##########
File path: CHANGES.txt
##########
@@ -1,4 +1,5 @@
4.0-alpha4
+ * Fix cqlsh output test (CASSANDRA-15707)
Review comment:
i'm not too sure we need non-user entries in `CHANGES.txt`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] nastra commented on a change in pull request #527:
CASSANDRA-15707: Fix cqlsh output test
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #527: CASSANDRA-15707: Fix cqlsh output test
URL: https://github.com/apache/cassandra/pull/527#discussion_r405457350
##########
File path: CHANGES.txt
##########
@@ -1,4 +1,5 @@
4.0-alpha4
+ * Fix cqlsh output test (CASSANDRA-15707)
Review comment:
there are a bunch of entries in CHANGES.txt that are for test fixes, so I did the same but personally either work for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request
#527: CASSANDRA-15707: Fix cqlsh output test
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #527: CASSANDRA-15707: Fix cqlsh output test
URL: https://github.com/apache/cassandra/pull/527#discussion_r405439570
##########
File path: CHANGES.txt
##########
@@ -1,4 +1,5 @@
4.0-alpha4
+ * Fix cqlsh output test (CASSANDRA-15707)
Review comment:
i'm not too sure we need non-user-facing entries in `CHANGES.txt`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] nastra closed pull request #527: CASSANDRA-15707: Fix
cqlsh output test
Posted by GitBox <gi...@apache.org>.
nastra closed pull request #527: CASSANDRA-15707: Fix cqlsh output test
URL: https://github.com/apache/cassandra/pull/527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] blerer commented on a change in pull request #527:
CASSANDRA-15707: Fix cqlsh output test
Posted by GitBox <gi...@apache.org>.
blerer commented on a change in pull request #527: CASSANDRA-15707: Fix cqlsh output test
URL: https://github.com/apache/cassandra/pull/527#discussion_r405490802
##########
File path: CHANGES.txt
##########
@@ -1,4 +1,5 @@
4.0-alpha4
+ * Fix cqlsh output test (CASSANDRA-15707)
Review comment:
Normally it is only user impacting changes. Not sure why people put them there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] nastra commented on issue #527: CASSANDRA-15707: Fix
cqlsh output test
Posted by GitBox <gi...@apache.org>.
nastra commented on issue #527: CASSANDRA-15707: Fix cqlsh output test
URL: https://github.com/apache/cassandra/pull/527#issuecomment-611585825
committed as 3db7796c1b7aa0e953fab621c0334c576cc7da35
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org