[GitHub] [superset] geido commented on a diff in pull request #21482: feat: Making bar graphs in Table viz from fixed-size divs instead of calculated gradients

[GitBox <gi...@apache.org>]

geido commented on code in PR #21482:
URL: https://github.com/apache/superset/pull/21482#discussion_r974137608


##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -449,6 +491,15 @@ export default function TableChart<D extends DataRecord = DataRecord>(
           // render `Cell`. This saves some time for large tables.
           return (
             <StyledCell {...cellProps}>
+              {valueRange && (
+                <div
+                  className={cx(
+                    'cell-bar',
+                    value && value < 0 ? 'negative' : 'positive',

Review Comment:
   I think this is an important one!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org