You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/19 20:40:28 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

TheNeuralBit commented on a change in pull request #11744:
URL: https://github.com/apache/beam/pull/11744#discussion_r427586062



##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -164,10 +165,19 @@ def add_runner_options(parser):
     all_options = self.options.get_all_options(
         add_extra_args_fn=add_runner_options,
         retain_unknown_options=self._retain_unknown_options)
+
     # TODO: Define URNs for options.
     # convert int values: https://issues.apache.org/jira/browse/BEAM-5509
+    def convert_pipeline_option_value(v):
+      if type(v) == int:

Review comment:
       Good question. I was just maintaining the status quo and adding a special case for `ValueProvider`. Let me see if I can dig up why the str(v) is there for ints




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org