[jira] [Commented] (PDFBOX-5522) Add public void save(COSWriter writer) to PDDocument

["Andreas Lehmkühler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612052#comment-17612052 ] 

Andreas Lehmkühler commented on PDFBOX-5522:
--------------------------------------------

I don't like the idea as it would indirectly make COSWriter a public class as well. IMHO COSWriter is supposed to be an internal class as it contains a lot of complex stuff. Furthermore there may be a rewrite of the whole class in a future major release and making it public would make it harder to do so.

What kind of checks and/or required conversion to you have in mind? Why not providing a patch to include those changes in PDFBox?

> Add public void save(COSWriter writer) to PDDocument
> ----------------------------------------------------
>
>                 Key: PDFBOX-5522
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5522
>             Project: PDFBox
>          Issue Type: New Feature
>          Components: PDModel
>    Affects Versions: 2.0.28, 3.0.0 PDFBox
>            Reporter: Stefan Ziegler
>            Priority: Minor
>         Attachments: PDDocument.java.patch
>
>
> Please add the following method to PDDocument:
>  
> {code:java}
> public void save(COSWriter writer){code}
>  
> Why?
> This gives us the possibility to use a custom COSWriter when saving the PDF file. Inside the custom COSWriter we can add some checks and convert some data structures if required.
>  
> Patch is attached.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org