You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/08/24 13:40:48 UTC
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/
-----------------------------------------------------------
(Updated Aug. 24, 2018, 1:40 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Summary (updated)
-----------------
Added --skip-verify flag to verify-reviews.py to skip verification.
Repository: mesos
Description (updated)
-------
This flag allows devs to skip verification and just print or
write to a file the review ids that need verification.
Diffs (updated)
-----
support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
Diff: https://reviews.apache.org/r/68497/diff/4/
Changes: https://reviews.apache.org/r/68497/diff/3-4/
Testing
-------
python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
Thanks,
Dragos Schebesch
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207881
-----------------------------------------------------------
PASS: Mesos patch 68497 was successfully built and tested.
Reviews applied: `['68497']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2233/mesos-review-68497
- Mesos Reviewbot Windows
On Aug. 24, 2018, 1:40 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68497/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows devs to skip verification and just print or
> write to a file the review ids that need verification.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
>
>
> Diff: https://reviews.apache.org/r/68497/diff/4/
>
>
> Testing
> -------
>
> python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207878
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On Aug. 24, 2018, 3:40 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68497/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 3:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows devs to skip verification and just print or
> write to a file the review ids that need verification.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
>
>
> Diff: https://reviews.apache.org/r/68497/diff/4/
>
>
> Testing
> -------
>
> python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207880
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68497]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 24, 2018, 1:40 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68497/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows devs to skip verification and just print or
> write to a file the review ids that need verification.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
>
>
> Diff: https://reviews.apache.org/r/68497/diff/4/
>
>
> Testing
> -------
>
> python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
>
>
> Thanks,
>
> Dragos Schebesch
>
>