[jira] [Commented] (GIRAPH-387) GiraphRunner's better handling of configuration property arguments

["Avery Ching (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483761#comment-13483761 ] 

Avery Ching commented on GIRAPH-387:
------------------------------------

Looks great, but can you also please update getOptions() to reflect this?

    options.addOption("ca", "customArguments", true, "provide custom" +
        " arguments for the job configuration in the form:" +
        " <param1>=<value1>,<param2>=<value2> etc.");
                
> GiraphRunner's better handling of configuration property arguments
> ------------------------------------------------------------------
>
>                 Key: GIRAPH-387
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-387
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jaeho Shin
>            Priority: Minor
>         Attachments: GIRAPH-387.patch
>
>
> After GiraphConfiguration came along (GIRAPH-337?), GiraphRunner started to forget all configuration properties passed as -D arguments, and picked up by ToolRunner.  I'm submitting a one-line fix for that, plus a small improvement to GiraphRunner's {{-ca}} option.
> Previously, to pass multiple custom arguments over the {{-ca}} option, we had to join all the name=value pairs with comma and only the last one had effect.  This was not so practical for many of my use cases, so I made some change to GiraphRunner that let us use as many {{-ca}} options as we want.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira