You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2020/08/06 00:54:19 UTC

[GitHub] [incubator-teaclave] mssun opened a new pull request #402: Use byte array instead of base64 for image transfer making parsing faster

mssun opened a new pull request #402:
URL: https://github.com/apache/incubator-teaclave/pull/402


   ## Description
   
     - Use byte array instead of base64


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave] mssun merged pull request #402: Use byte array instead of base64 for image transfer making parsing faster

Posted by GitBox <gi...@apache.org>.
mssun merged pull request #402:
URL: https://github.com/apache/incubator-teaclave/pull/402


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave] yc-huang commented on pull request #402: Use byte array instead of base64 for image transfer making parsing faster

Posted by GitBox <gi...@apache.org>.
yc-huang commented on pull request #402:
URL: https://github.com/apache/incubator-teaclave/pull/402#issuecomment-669680296


   Do we need to tune the code of try_from implementation?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave] yc-huang commented on pull request #402: Use byte array instead of base64 for image transfer making parsing faster

Posted by GitBox <gi...@apache.org>.
yc-huang commented on pull request #402:
URL: https://github.com/apache/incubator-teaclave/pull/402#issuecomment-670302631


   I see, this is not for optimizing the on wire transfering size, but for optimizing the json decoding cost (e.g. memory comsumption...)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave] mssun commented on pull request #402: Use byte array instead of base64 for image transfer making parsing faster

Posted by GitBox <gi...@apache.org>.
mssun commented on pull request #402:
URL: https://github.com/apache/incubator-teaclave/pull/402#issuecomment-670088462


   @yc-huang what did you mean? The `try_from` function will deserialize `FaceDetectionArguments` based on its fields automatically. No need to change this function.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org