You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/30 08:20:29 UTC

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput

apeforest commented on a change in pull request #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r372809923
 
 

 ##########
 File path: python/mxnet/kvstore/kvstore.py
 ##########
 @@ -67,6 +68,7 @@ def __init__(self, handle):
         self._updater = None
         self._updater_func = None
         self._str_updater_func = None
+        self._is_p3 = (os.getenv('DMLC_PS_VAN_TYPE', '') == 'p3')
 
 Review comment:
   Could you clarify a bit more on this? According to this RFC (https://github.com/apache/incubator-mxnet/issues/16795), p3 will be treated as another kvstore just like byteps/horovod. Why would it be different?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services