You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by junichi11 <gi...@git.apache.org> on 2017/10/07 12:44:16 UTC
[GitHub] incubator-netbeans pull request #74: [NETBEANS-54] Module Review terminal
GitHub user junichi11 opened a pull request:
https://github.com/apache/incubator-netbeans/pull/74
[NETBEANS-54] Module Review terminal
- no external library
- checked Rat report: add the license header in README.*. ignore manifest.mf
- skimmed through the module, did not notice additional problems
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/junichi11/incubator-netbeans module-review-terminal
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 23c0cbe25bb4cd97a886730dba0fd85fab279d02
Author: Junichi Yamamoto <ju...@apache.org>
Date: 2017-10-07T12:38:18Z
[NETBEANS-54] Module Review terminal
- no external library
- checked Rat report: add the license header in README.*. ignore manifest.mf
- skimmed through the module, did not notice additional problems
----
---
[GitHub] incubator-netbeans issue #74: [NETBEANS-54] Module Review terminal
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/74
Looks good. I might have considered stripping the "#" signs, but that is bike-shedding, so no objection from me.
---
Re: [GitHub] incubator-netbeans issue #74: [NETBEANS-54] Module
Review terminal
Posted by Junichi Yamamoto <ju...@gmail.com>.
Hi,
Thank you for your help!
I'll do [1]. If other people prefer another choice, I'll fix it again.
Junichi
2017-10-08 6:39 GMT+09:00 Craig Russell <ap...@gmail.com>:
> Hi,
>
> IMO, you could do any of these:
>
> 1. ship it with the # comment lines as it is now
> 2. remove the # lines and add the file to rat excludes (no significant ip here)
> 3. use the "short form" license header
>
> Whatever is easiest and most like treatment of other such files.
>
> Craig
>
>> On Oct 7, 2017, at 2:26 PM, junichi11 <gi...@git.apache.org> wrote:
>>
>> Github user junichi11 commented on the issue:
>>
>> https://github.com/apache/incubator-netbeans/pull/74
>>
>> Yes, probably, "#" signs are not needed. I used them because I thought that the format should be unified.
>> It is already used in o.n.swing.tabcontrol/readme.txt[1].
>>
>> [1] https://github.com/apache/incubator-netbeans/blob/master/o.n.swing.tabcontrol/readme.txt
>>
>>
>> ---
>
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org http://db.apache.org/jdo
>
Re: [GitHub] incubator-netbeans issue #74: [NETBEANS-54] Module Review terminal
Posted by Craig Russell <ap...@gmail.com>.
Hi,
IMO, you could do any of these:
1. ship it with the # comment lines as it is now
2. remove the # lines and add the file to rat excludes (no significant ip here)
3. use the "short form" license header
Whatever is easiest and most like treatment of other such files.
Craig
> On Oct 7, 2017, at 2:26 PM, junichi11 <gi...@git.apache.org> wrote:
>
> Github user junichi11 commented on the issue:
>
> https://github.com/apache/incubator-netbeans/pull/74
>
> Yes, probably, "#" signs are not needed. I used them because I thought that the format should be unified.
> It is already used in o.n.swing.tabcontrol/readme.txt[1].
>
> [1] https://github.com/apache/incubator-netbeans/blob/master/o.n.swing.tabcontrol/readme.txt
>
>
> ---
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
[GitHub] incubator-netbeans issue #74: [NETBEANS-54] Module Review terminal
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/74
Yes, probably, "#" signs are not needed. I used them because I thought that the format should be unified.
It is already used in o.n.swing.tabcontrol/readme.txt[1].
[1] https://github.com/apache/incubator-netbeans/blob/master/o.n.swing.tabcontrol/readme.txt
---
[GitHub] incubator-netbeans pull request #74: [NETBEANS-54] Module Review terminal
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/74
---