You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/30 23:42:38 UTC

[GitHub] [arrow] nealrichardson commented on pull request #7018: ARROW-8536: [Rust] [Flight] Check in proto file, conditional build if file exists

nealrichardson commented on pull request #7018:
URL: https://github.com/apache/arrow/pull/7018#issuecomment-622177076


   So `rust/arrow-flight/src/arrow.flight.protocol.rs` is generated from `format/Flight.proto`? There is precedent for adding generated files to `rat_excluded_files.txt`, so I think that's fine, though IMO it would be a really good idea to prepend a comment to the generated file that points back to the source and indicates that it should not be edited by hand.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org