You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/10 02:01:55 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #11373: [BEAM-9562] Update Element.timer to Element.timers

lukecwik commented on a change in pull request #11373: [BEAM-9562] Update Element.timer to Element.timers
URL: https://github.com/apache/beam/pull/11373#discussion_r406567717
 
 

 ##########
 File path: model/fn-execution/src/main/proto/beam_fn_api.proto
 ##########
 @@ -516,7 +516,7 @@ message Elements {
   repeated Data data = 1;
 
   // (Optional)  A list of timer byte streams.
-  repeated Timer timer = 2;
+  repeated Timer timers = 2;
 
 Review comment:
   @robertwb did you want to rename this field or the proto message Timer -> Timers or both?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services