You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/08 02:18:01 UTC

[GitHub] [incubator-uniffle] jerqi opened a new pull request, #140: [MINOR][IMPROVEMENT][SERVER] Fix server module code style

jerqi opened a new pull request, #140:
URL: https://github.com/apache/incubator-uniffle/pull/140

   ### What changes were proposed in this pull request?
   Solve issue https://github.com/apache/incubator-uniffle/issues/123,  solve storage module code style problems
   
   ### Why are the changes needed?
   Improve our test code style
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   I add the test code style check commits, storage module passed.
   https://github.com/jerqi/incubator-uniffle/runs/7691133341?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi closed pull request #140: [MINOR][IMPROVEMENT][SERVER] Fix server module code style

Posted by GitBox <gi...@apache.org>.
jerqi closed pull request #140: [MINOR][IMPROVEMENT][SERVER] Fix server module code style
URL: https://github.com/apache/incubator-uniffle/pull/140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #140: [MINOR][IMPROVEMENT][SERVER] Fix server module code style

Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #140:
URL: https://github.com/apache/incubator-uniffle/pull/140#discussion_r939793496


##########
server/src/test/java/org/apache/uniffle/server/StorageCheckerTest.java:
##########
@@ -101,6 +102,8 @@ long getUsedSpace(File file) {
         case "st2":
           switch (callTimes) {
             case 0:
+              result = 200;
+              break;

Review Comment:
   Is this change necessary?
   
   See: https://checkstyle.sourceforge.io/config_coding.html#FallThrough



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org