[GitHub] ashokei commented on a change in pull request #12008: [WIP] Enable graph partitioning in executor with types/shape awareness

[GitBox <gi...@apache.org>]

ashokei commented on a change in pull request #12008: [WIP] Enable graph partitioning in executor with types/shape awareness 
URL: https://github.com/apache/incubator-mxnet/pull/12008#discussion_r207688584
 
 

 ##########
 File path: src/operator/subgraph/default_subgraph_op.h
 ##########
 @@ -121,6 +146,25 @@ class DefaultSubgraphProperty: public SubgraphProperty {
   std::shared_ptr<const std::unordered_set<std::string>> op_names_;
 };
 
+/*
+ * This subgraph property finds a subgraph whose nodes satisfy shape/types requirement.
+ * The operators in the subgraph will be executed by _default_subgraph_op.
+ */
+class ShapeTypesSubgraphProperty : public SubgraphProperty {
 
 Review comment:
   i removed this for now, will submit separate PR for custom selector.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services