You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/21 14:00:00 UTC

[GitHub] [superset] codecov[bot] commented on pull request #24471: fix(oracle): denormalize column names where applicable

codecov[bot] commented on PR #24471:
URL: https://github.com/apache/superset/pull/24471#issuecomment-1600892275

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#24471](https://app.codecov.io/gh/apache/superset/pull/24471?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e11b8c1) into [master](https://app.codecov.io/gh/apache/superset/commit/d5f88c18f61cc919a8bdecfa92251d0d4d35abac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d5f88c1) will **decrease** coverage by `10.99%`.
   > The diff coverage is `83.33%`.
   
   > :exclamation: Current head e11b8c1 differs from pull request most recent head 35a4b05. Consider uploading reports for the commit 35a4b05 to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #24471       +/-   ##
   ===========================================
   - Coverage   69.03%   58.04%   -10.99%     
   ===========================================
     Files        1901     1901               
     Lines       74002    74008        +6     
     Branches     8116     8116               
   ===========================================
   - Hits        51086    42958     -8128     
   - Misses      20805    28939     +8134     
     Partials     2111     2111               
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `53.83% <33.33%> (-0.01%)` | :arrow_down: |
   | python | `60.63% <83.33%> (-22.87%)` | :arrow_down: |
   | sqlite | `?` | |
   | unit | `54.68% <83.33%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/sqla/utils.py](https://app.codecov.io/gh/apache/superset/pull/24471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `79.34% <0.00%> (-10.77%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://app.codecov.io/gh/apache/superset/pull/24471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `76.90% <100.00%> (-14.00%)` | :arrow_down: |
   
   ... and [299 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24471/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org