You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/02 04:00:49 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' in split
HyukjinKwon opened a new pull request #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' in split
URL: https://github.com/apache/spark/pull/27756
### What changes were proposed in this pull request?
To address the concern pointed out in https://github.com/apache/spark/pull/22227. This will make `split` source-compatible by removing minimal cosmetic changes.
### Why are the changes needed?
For source compatibility.
### Does this PR introduce any user-facing change?
No (it will prevent potential user-facing change from the original PR)
### How was this patch tested?
Unittest was changed (in order for us to detect that source compatibility easily).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593208436
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593422155
**[Test build #119165 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119165/testReport)** for PR 27756 at commit [`4d1a86f`](https://github.com/apache/spark/commit/4d1a86fcc175bda9a75808096cea7343cd2bf3ca).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#discussion_r386539301
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -2463,22 +2463,22 @@ object functions {
* Splits str around matches of the given regex.
Review comment:
nit: This general comment refers to parameters, it seems. And `pattern` was replaced by `regex` here in in the original PR. How about _Splits str around matches of the given **pattern**_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593323252
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593271878
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119151/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593717191
Oops, mistake. I was removing my old branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593208241
**[Test build #119151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119151/testReport)** for PR 27756 at commit [`4d1a86f`](https://github.com/apache/spark/commit/4d1a86fcc175bda9a75808096cea7343cd2bf3ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593322667
**[Test build #119165 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119165/testReport)** for PR 27756 at commit [`4d1a86f`](https://github.com/apache/spark/commit/4d1a86fcc175bda9a75808096cea7343cd2bf3ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593208436
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593323252
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593423082
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119165/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593271862
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593423072
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593271878
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119151/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593717807
Thanks guys. I am going to merge this because the last change was comment-only. I locally ran the Scala linter to make sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593717910
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593271862
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593322276
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593423072
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593208440
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23893/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593271653
**[Test build #119151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119151/testReport)** for PR 27756 at commit [`4d1a86f`](https://github.com/apache/spark/commit/4d1a86fcc175bda9a75808096cea7343cd2bf3ca).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593322667
**[Test build #119165 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119165/testReport)** for PR 27756 at commit [`4d1a86f`](https://github.com/apache/spark/commit/4d1a86fcc175bda9a75808096cea7343cd2bf3ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593323257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23908/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593208241
**[Test build #119151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119151/testReport)** for PR 27756 at commit [`4d1a86f`](https://github.com/apache/spark/commit/4d1a86fcc175bda9a75808096cea7343cd2bf3ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon opened a new pull request #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon opened a new pull request #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756
### What changes were proposed in this pull request?
To address the concern pointed out in https://github.com/apache/spark/pull/22227. This will make `split` source-compatible by removing minimal cosmetic changes.
### Why are the changes needed?
For source compatibility.
### Does this PR introduce any user-facing change?
No (it will prevent potential user-facing change from the original PR)
### How was this patch tested?
Unittest was changed (in order for us to detect that source compatibility easily).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593423082
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119165/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593323257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23908/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27756:
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at
split in Scala API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27756: [SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API
URL: https://github.com/apache/spark/pull/27756#issuecomment-593208440
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23893/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org