You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/21 10:49:14 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5798: ui: prevent incorrect tags displa for primary storage
shwstppr opened a new pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798
### Description
Tags in info card of the UI are related to tags functionality(create/delete/lsitTags API)
UI was incorrectly showing storage tags as these tags in the UI.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Before:
After:
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Using UI
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5798: ui: prevent incorrect tags display for primary storage
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-1000072827
Thanks for fix @shwstppr. #5727 bug also reports about tags for host, Can you please consider fixing that as well, it says after adding tags, it is not displaying the tags. I've checked that and there is an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5798: ui: prevent incorrect tags display for primary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-998682298
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5798 (SL-JID-923)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-1000121670
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5798 (SL-JID-929)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-1000088231
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5798: ui: prevent incorrect tags displa for primary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-998677715
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-1000090197
UI build: :heavy_multiplication_x:
(SL-JID-928)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-1000119450
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5798: ui: prevent incorrect tags display for primary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#discussion_r773034265
##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -772,7 +772,8 @@ export default {
this.showKeys = false
this.setData()
- if ('tags' in this.resource) {
+ console.log(this.resourceType)
Review comment:
remove console logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5798: ui: prevent incorrect tags display for primary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-998678451
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5798: ui: prevent incorrect tags display for primary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-998703242
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5798 (SL-JID-924)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5798: ui: prevent incorrect tags display for primary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-998699870
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-1000118861
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#discussion_r774400570
##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -794,6 +796,12 @@ export default {
await this.getIcons()
},
computed: {
+ tagsSupportingResourceTypes () {
+ return ['UserVm', 'Template', 'ISO', 'Volume', 'Snapshot', 'Backup', 'Network',
+ 'LoadBalancer', 'PortForwardingRule', 'FirewallRule', 'SecurityGroup', 'SecurityGroupRule',
+ 'PublicIpAddress', 'Project', 'Account', 'Vpc', 'NetworkACL', 'StaticRoute', 'VMSnapshot',
+ 'RemoteAccessVpn', 'User', 'SnapshotPolicy', 'VpcOffering']
Review comment:
@shwstppr Is this the complete resources list supporting tags? how about keeping unsupported resource types only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5798: ui: prevent incorrect tags display for primary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#discussion_r773055833
##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -772,7 +772,8 @@ export default {
this.showKeys = false
this.setData()
- if ('tags' in this.resource) {
+ console.log(this.resourceType)
Review comment:
@rhtyd done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5798: ui: prevent incorrect tags display for primary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-998700048
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-1000087391
@harikrishna-patnala made change to show tags only for supported resource types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#issuecomment-1000088113
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5798: ui: show tags only for supported resources
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5798:
URL: https://github.com/apache/cloudstack/pull/5798#discussion_r776255235
##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -794,6 +796,12 @@ export default {
await this.getIcons()
},
computed: {
+ tagsSupportingResourceTypes () {
+ return ['UserVm', 'Template', 'ISO', 'Volume', 'Snapshot', 'Backup', 'Network',
+ 'LoadBalancer', 'PortForwardingRule', 'FirewallRule', 'SecurityGroup', 'SecurityGroupRule',
+ 'PublicIpAddress', 'Project', 'Account', 'Vpc', 'NetworkACL', 'StaticRoute', 'VMSnapshot',
+ 'RemoteAccessVpn', 'User', 'SnapshotPolicy', 'VpcOffering']
Review comment:
@sureshanaparti some of the resource types used in the UI are not even present in the backend, https://github.com/shapeblue/cloudstack/blob/4.16/ui/src/config/section/infra/primaryStorages.js#L42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org