You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/04/14 17:34:47 UTC

Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46212/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-3923
    https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
-------

This change adds config docs around authenticating HTTP
frameworks using the newly introduced flags. Also added a
small note to the `authenticate` flag that this does not
work for HTTP based frameworks.


Diffs
-----

  docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 

Diff: https://reviews.apache.org/r/46212/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46212/#review128926
-----------------------------------------------------------



Could we add a section to 'docs/authentication.md' about authenticating HTTP frameworks as well?

- Greg Mann


On April 14, 2016, 3:34 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46212/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3923
>     https://issues.apache.org/jira/browse/MESOS-3923
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds config docs around authenticating HTTP
> frameworks using the newly introduced flags. Also added a
> small note to the `authenticate` flag that this does not
> work for HTTP based frameworks.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 
> 
> Diff: https://reviews.apache.org/r/46212/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46212/#review129048
-----------------------------------------------------------



Update the docs based on the previous review's changes.

- Vinod Kone


On April 14, 2016, 3:34 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46212/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3923
>     https://issues.apache.org/jira/browse/MESOS-3923
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds config docs around authenticating HTTP
> frameworks using the newly introduced flags. Also added a
> small note to the `authenticate` flag that this does not
> work for HTTP based frameworks.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 
> 
> Diff: https://reviews.apache.org/r/46212/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46212/#review129183
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On April 15, 2016, 7:04 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46212/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3923
>     https://issues.apache.org/jira/browse/MESOS-3923
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds config docs around authenticating HTTP
> frameworks using the newly introduced flags. Also added a
> small note to the `authenticate` flag that this does not
> work for HTTP based frameworks.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 
> 
> Diff: https://reviews.apache.org/r/46212/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46212/
-----------------------------------------------------------

(Updated April 15, 2016, 7:04 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Review comments


Bugs: MESOS-3923
    https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
-------

This change adds config docs around authenticating HTTP
frameworks using the newly introduced flags. Also added a
small note to the `authenticate` flag that this does not
work for HTTP based frameworks.


Diffs (updated)
-----

  docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 

Diff: https://reviews.apache.org/r/46212/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46212/
-----------------------------------------------------------

(Updated April 15, 2016, 4:39 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Explicitly mentioned that authenticators are loaded only when framework AuthN is enabled.


Bugs: MESOS-3923
    https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
-------

This change adds config docs around authenticating HTTP
frameworks using the newly introduced flags. Also added a
small note to the `authenticate` flag that this does not
work for HTTP based frameworks.


Diffs (updated)
-----

  docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 

Diff: https://reviews.apache.org/r/46212/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar