You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/23 16:30:07 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #20483: fix: bump FAB to 4.1.2
dpgaspar opened a new pull request, #20483:
URL: https://github.com/apache/superset/pull/20483
### SUMMARY
Improvements and Bug fixes on 4.1.2
- fix: remove sqlite dbs from examples (#1853) [Daniel Vaz Gaspar]
- fix(MVC): discard excluded filters from query (#1862) [Daniel Vaz Gaspar]
Improvements and Bug fixes on 4.1.1
- fix: custom security class import, bad cast (#1851) [Daniel Vaz Gaspar]
- fix: Set certificates before reconnecting to LDAP (#1846) [Sebastian Bernauer]
Improvements and Bug fixes on 4.1.0
- docs: add FAB_ADD_SECURITY_API config option (#1840) [Daniel Vaz Gaspar]
- feat: add keycloak auth provider options (#1832) [nilivingston]
- docs: add Azure OAUTH example (#1837) [Mathew Wicks]
- fix: security api (#1831) [Daniel Vaz Gaspar]
- fix: dependency constraints, bump flask-login, flask-wtf (#1838) [Daniel Vaz Gaspar]
- fix: noop user update on Auth db, use set user model (#1834) [Daniel Vaz Gaspar]
- chore: bump postgres to 14 (#1833) [Daniel Vaz Gaspar]
- chore: Update and fix german translation (#1827) [Dosenpfand]
- chore: Enhance is_safe_redirect_url (#1826) [Geido]
- feat: Add CRUD apis for role, permission, user (#1801) [Mayur]
- docs: updated brackets in OAuth Authentication (#1798) [David Berg]
- chore: add Slovenian language (#1828) [dkrat7]
- fix: doc requirements (#1820) [Daniel Vaz Gaspar]
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20483: fix: bump FAB to 4.1.2
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20483:
URL: https://github.com/apache/superset/pull/20483#issuecomment-1164703903
# [Codecov](https://codecov.io/gh/apache/superset/pull/20483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20483](https://codecov.io/gh/apache/superset/pull/20483?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d79ad4d) into [master](https://codecov.io/gh/apache/superset/commit/aa4068048a779359b21d2fa3e2c0328a0dd754ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa40680) will **increase** coverage by `3.58%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #20483 +/- ##
==========================================
+ Coverage 51.20% 54.79% +3.58%
==========================================
Files 1740 1740
Lines 65156 65156
Branches 6900 6900
==========================================
+ Hits 33362 35699 +2337
+ Misses 30045 27708 -2337
Partials 1749 1749
```
| Flag | Coverage Δ | |
|---|---|---|
| presto | `53.57% <100.00%> (?)` | |
| python | `58.00% <100.00%> (+7.44%)` | :arrow_up: |
| unit | `50.55% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `87.30% <100.00%> (ø)` | |
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `86.36% <100.00%> (ø)` | |
| [superset/views/annotations.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `81.96% <100.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `96.66% <100.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `85.00% <100.00%> (ø)` | |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `56.29% <100.00%> (ø)` | |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `84.07% <0.00%> (+0.63%)` | :arrow_up: |
| [superset/models/slice.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `58.45% <0.00%> (+0.96%)` | :arrow_up: |
| [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `91.51% <0.00%> (+1.06%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `99.35% <0.00%> (+1.94%)` | :arrow_up: |
| ... and [76 more](https://codecov.io/gh/apache/superset/pull/20483/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20483?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20483?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa40680...d79ad4d](https://codecov.io/gh/apache/superset/pull/20483?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #20483: fix: bump FAB to 4.1.2
Posted by GitBox <gi...@apache.org>.
dpgaspar merged PR #20483:
URL: https://github.com/apache/superset/pull/20483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org