[jira] [Commented] (OFBIZ-4656) Enforcing Noninstantiability to Utility Classes in OFBiz

["Adrian Crum (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184747#comment-13184747 ] 

Adrian Crum commented on OFBIZ-4656:
------------------------------------

Thanks Rishi! Please remove the comments. We usually reserve comments for code that is unusual or hard to understand, and private constructors are understood by most Java programmers.

                
> Enforcing Noninstantiability to Utility Classes in OFBiz
> --------------------------------------------------------
>
>                 Key: OFBIZ-4656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4656
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product
>            Reporter: Rishi Solanki
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4656.patch
>
>
> With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results
> Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java
> There may be few more, will found and fix them soon.
> I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira