You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/31 09:22:13 UTC
[GitHub] [spark] xuanyuanking opened a new pull request #29315: [SPARK-31894][SS][FOLLOW-UP]
xuanyuanking opened a new pull request #29315:
URL: https://github.com/apache/spark/pull/29315
### What changes were proposed in this pull request?
Address comment in https://github.com/apache/spark/pull/28707#discussion_r461102749
### Why are the changes needed?
Hide the implementation details in the config doc.
### Does this PR introduce _any_ user-facing change?
Config doc change.
### How was this patch tested?
Document only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #29315:
URL: https://github.com/apache/spark/pull/29315#discussion_r463517304
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1236,7 +1236,7 @@ object SQLConf {
val STATE_STORE_FORMAT_VALIDATION_ENABLED =
buildConf("spark.sql.streaming.stateStore.formatValidation.enabled")
.internal()
- .doc("When true, check if the UnsafeRow from the state store is valid or not when running " +
+ .doc("When true, check if the checkpoint from the state store is valid or not when running " +
Review comment:
Thanks, fix done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29315:
URL: https://github.com/apache/spark/pull/29315#discussion_r463507332
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1236,7 +1236,7 @@ object SQLConf {
val STATE_STORE_FORMAT_VALIDATION_ENABLED =
buildConf("spark.sql.streaming.stateStore.formatValidation.enabled")
.internal()
- .doc("When true, check if the UnsafeRow from the state store is valid or not when running " +
+ .doc("When true, check if the checkpoint from the state store is valid or not when running " +
Review comment:
`checkpoint from the state store` looks a bit weird. `data from the state store`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667229815
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667229815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667030482
cc @HeartSaVioR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667029157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667228429
**[Test build #126883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126883/testReport)** for PR 29315 at commit [`376989d`](https://github.com/apache/spark/commit/376989d11395d79892c93da40559ed4188594d02).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667085637
**[Test build #126883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126883/testReport)** for PR 29315 at commit [`376989d`](https://github.com/apache/spark/commit/376989d11395d79892c93da40559ed4188594d02).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #29315:
URL: https://github.com/apache/spark/pull/29315#discussion_r463517078
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1236,9 +1236,9 @@ object SQLConf {
val STATE_STORE_FORMAT_VALIDATION_ENABLED =
buildConf("spark.sql.streaming.stateStore.formatValidation.enabled")
.internal()
- .doc("When true, check if the UnsafeRow from the state store is valid or not when running " +
- "streaming queries. This can happen if the state store format has been changed. Note, " +
- "the feature is only effective in the build-in HDFS state store provider now.")
+ .doc("When true, check if the date from state store is valid or not when running streaming " +
Review comment:
😂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29315:
URL: https://github.com/apache/spark/pull/29315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667127016
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667439223
post +1. Thanks for the fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667039785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667142325
This just updates the config doc and we don't need to wait for the test. Thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667026221
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667126528
**[Test build #126880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126880/testReport)** for PR 29315 at commit [`a358345`](https://github.com/apache/spark/commit/a358345e1dcda0b8be54d6386c0dd81410bbc77b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667030342
do we have the same problem in the error message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667127016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667127024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126880/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667029157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667229826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126883/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29315:
URL: https://github.com/apache/spark/pull/29315#discussion_r463515692
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1236,9 +1236,9 @@ object SQLConf {
val STATE_STORE_FORMAT_VALIDATION_ENABLED =
buildConf("spark.sql.streaming.stateStore.formatValidation.enabled")
.internal()
- .doc("When true, check if the UnsafeRow from the state store is valid or not when running " +
- "streaming queries. This can happen if the state store format has been changed. Note, " +
- "the feature is only effective in the build-in HDFS state store provider now.")
+ .doc("When true, check if the date from state store is valid or not when running streaming " +
Review comment:
data...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667081276
**[Test build #126880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126880/testReport)** for PR 29315 at commit [`a358345`](https://github.com/apache/spark/commit/a358345e1dcda0b8be54d6386c0dd81410bbc77b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667032181
https://github.com/apache/spark/pull/28707/files#diff-238c6b2f820f62c556f204788d684584R150
I think the error message is clear, we don't use code name inside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667085637
**[Test build #126883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126883/testReport)** for PR 29315 at commit [`376989d`](https://github.com/apache/spark/commit/376989d11395d79892c93da40559ed4188594d02).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29315:
URL: https://github.com/apache/spark/pull/29315#issuecomment-667081276
**[Test build #126880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126880/testReport)** for PR 29315 at commit [`a358345`](https://github.com/apache/spark/commit/a358345e1dcda0b8be54d6386c0dd81410bbc77b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org