[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35504: [SPARK-38194][YARN][MESOS][K8S] Make memory overhead factor configurable

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #35504:
URL: https://github.com/apache/spark/pull/35504#discussion_r807293853



##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -636,7 +636,9 @@ private[spark] object SparkConf extends Logging {
       DeprecatedConfig("spark.blacklist.killBlacklistedExecutors", "3.1.0",
         "Please use spark.excludeOnFailure.killExcludedExecutors"),
       DeprecatedConfig("spark.yarn.blacklist.executor.launch.blacklisting.enabled", "3.1.0",
-        "Please use spark.yarn.executor.launch.excludeOnFailure.enabled")
+        "Please use spark.yarn.executor.launch.excludeOnFailure.enabled"),
+      DeprecatedConfig("spark.kubernetes.memoryOverheadFactor", "3.3.0",

Review comment:
       This seems wrong and inconsistent with this PR because this PR uses `spark.kubernetes.memoryOverheadFactor` to override the driver or executor specific configurations.
   ```
     private val memoryOverheadFactor = conf.get(MEMORY_OVERHEAD_FACTOR)
        .getOrElse(conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org