You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Benoit Tellier (Jira)" <se...@james.apache.org> on 2022/01/19 10:00:00 UTC
[jira] [Commented] (JAMES-3705) Extensible POP3 handlers
[ https://issues.apache.org/jira/browse/JAMES-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478513#comment-17478513 ]
Benoit Tellier commented on JAMES-3705:
---------------------------------------
Why not allowing some/all of the statistics you mention, which sounds generic enough, to make it in James codebase if applicable (eg use of MetricsFactory) rather than keeping a lonely protected method?
> Extensible POP3 handlers
> ------------------------
>
> Key: JAMES-3705
> URL: https://issues.apache.org/jira/browse/JAMES-3705
> Project: James Server
> Issue Type: Improvement
> Components: POP3Server
> Affects Versions: master
> Reporter: Karsten Otto
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I propose a minor refactoring of the POP3 {{{}RetrCmdHandler{}}}, retrieving the message content in a separate protected method:
>
> {code:java}
> protected InputStream getMessageContent(POP3Session session, MessageMetaData data){code}
> With this developers can more easily create custom variants of this command, to access the session and message metadata, wrap the message stream to e.g. gather transfer statistics and monitor ultimate success/failure.
> Since the {{TopCmdHandler}} extends {{{}RetrCmdHandler{}}}, it can trivially use this method as well for the same benefit.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org