You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/08 12:05:24 UTC
[GitHub] [iceberg-docs] singhpk234 opened a new pull request #47: Fix spec.md
singhpk234 opened a new pull request #47:
URL: https://github.com/apache/iceberg-docs/pull/47
This change tries fix :
[1] achor links :
For ex
On clicking position delete in `https://iceberg.apache.org/spec/` in `Row-level Deletes` i get redirected to `https://iceberg.apache.org/#position-delete-files` ideally this should be `https://iceberg.apache.org/spec/#position- delete-files`
[2] broken external link from [3-level representation](https://github.com/apache/parquet-format/blob/master/LogicalTypes#lists) to [3-level representation](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on pull request #47: Fix spec.md
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #47:
URL: https://github.com/apache/iceberg-docs/pull/47#issuecomment-1032763636
LGTM, thanks @singhpk234!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] rdblue commented on pull request #47: Fix spec.md
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #47:
URL: https://github.com/apache/iceberg-docs/pull/47#issuecomment-1034355089
Thanks, @singhpk234!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] rdblue commented on a change in pull request #47: Fix spec.md
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #47:
URL: https://github.com/apache/iceberg-docs/pull/47#discussion_r801799463
##########
File path: landing-page/content/common/format/spec.md
##########
@@ -34,15 +34,15 @@ The format version number is incremented when new features are added that will b
Version 1 of the Iceberg spec defines how to manage large analytic tables using immutable file formats: Parquet, Avro, and ORC.
-All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](#version-2) documents how to default version 2 fields when reading version 1 metadata.
+All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](spec/#version-2) documents how to default version 2 fields when reading version 1 metadata.
Review comment:
@samredai, any idea why bare anchor links don't keep you on the same page for the spec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on a change in pull request #47: Fix spec.md
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #47:
URL: https://github.com/apache/iceberg-docs/pull/47#discussion_r803205298
##########
File path: landing-page/content/common/format/spec.md
##########
@@ -34,15 +34,15 @@ The format version number is incremented when new features are added that will b
Version 1 of the Iceberg spec defines how to manage large analytic tables using immutable file formats: Parquet, Avro, and ORC.
-All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](#version-2) documents how to default version 2 fields when reading version 1 metadata.
+All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](spec/#version-2) documents how to default version 2 fields when reading version 1 metadata.
Review comment:
It's definitely an unexpected behavior. I'll take a closer look into this and see if there's something in the theme we can tweak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] rdblue commented on a change in pull request #47: Fix spec.md
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #47:
URL: https://github.com/apache/iceberg-docs/pull/47#discussion_r801799463
##########
File path: landing-page/content/common/format/spec.md
##########
@@ -34,15 +34,15 @@ The format version number is incremented when new features are added that will b
Version 1 of the Iceberg spec defines how to manage large analytic tables using immutable file formats: Parquet, Avro, and ORC.
-All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](#version-2) documents how to default version 2 fields when reading version 1 metadata.
+All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](spec/#version-2) documents how to default version 2 fields when reading version 1 metadata.
Review comment:
@samredai, any idea why anchor links don't keep you on the same page for the spec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] rdblue merged pull request #47: Fix spec.md
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #47:
URL: https://github.com/apache/iceberg-docs/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org