You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Maksim Myskov <my...@apache.org> on 2024/11/22 11:35:14 UTC
[DISCUSSION] IEP-130: Spring Boot support
Hello Ignite devs,
Please, take a look at the proposal for Ignite3
https://cwiki.apache.org/confluence/display/IGNITE/IEP-130%3A+Spring+Boot+support
--
Maksim Myskov
Re: [DISCUSSION] IEP-130: Spring Boot support
Posted by Ilya Korol <ll...@gmail.com>.
Hi, Maksim.
First of all, thanks for your efforts.
I have one concern, and probably I'm over exaggerating this problem, but
which Spring version we're targeting? Spring 6? What we're going to do
if, let's say after couple of years, Spring 7 will appear
<https://spring.io/blog/2024/10/01/from-spring-framework-6-2-to-7-0>
that won't be totally compatible with Spring 6?
So what I'm trying to highlight is should we try to use more
sophisticated approach for Spring extension module naming? I.e. instead
of *ignite-autoconfigure:3.0.0* we can have
*ignite-spring6-autoconfigure:3.0.0*. In case of new Spring 7 we could
simply spawn a new dedicated module for S7 and there would be no
uncertainty for end user that he need to pick.
On 22.11.2024 13:35, Maksim Myskov wrote:
> Hello Ignite devs,
>
> Please, take a look at the proposal for Ignite3
>
> https://cwiki.apache.org/confluence/display/IGNITE/IEP-130%3A+Spring+Boot+support
>
> --
> Maksim Myskov
>
>
Re: [DISCUSSION] IEP-130: Spring Boot support
Posted by Pavel Tupitsyn <pt...@apache.org>.
Ok, this makes sense, thank you.
On Tue, Dec 3, 2024 at 4:30 PM Maxim Myskov <ma...@gmail.com> wrote:
> Yes, it would be easier to manage configs if they could be identical on
> all nodes. This would avoid situations where several nodes have this flag
> (in case if it is a flag) enabled.
> --
> Maksim Myskov
>
> > On 3 Dec 2024, at 17:13, Pavel Tupitsyn <pt...@apache.org> wrote:
> >
> >> adding the "ignite.bootstrap.nodeName" property to define the node that
> > performs cluster initialization on startup
> >
> > Why node name and not a boolean flag?
> > Is that so the config is the same on all nodes, but only the node with
> the
> > matching name starts initialization?
> >
> > On Tue, Dec 3, 2024 at 3:56 PM Maxim Myskov <ma...@gmail.com>
> wrote:
> >
> >> Hello Pavel,
> >>
> >> What do you think about the approach?
> >>
> >> --
> >> Maksim Myskov
> >>
> >>> On 28 Nov 2024, at 11:54, Maxim Myskov <ma...@gmail.com> wrote:
> >>>
> >>> Hello Pavel,
> >>>
> >>> I updated the "Embedded mode” section, please take a look.
> >>> In short, I propose adding the "ignite.bootstrap.nodeName" property to
> >> define the node that performs cluster initialization on startup.
> >>> I look forward to receiving feedback on this approach.
> >>>
> >>> --
> >>> Maksim Myskov
> >>>
> >>>> On 22 Nov 2024, at 14:49, Pavel Tupitsyn <pt...@apache.org>
> wrote:
> >>>>
> >>>> Hello Maksim,
> >>>>
> >>>> The proposal looks good in general.
> >>>>
> >>>> I think we need more details on cluster initialization mechanism - who
> >>>> calls init and when? What if there are multiple Spring-based embedded
> >> nodes?
> >>>>
> >>>> On Fri, Nov 22, 2024 at 1:36 PM Maksim Myskov <my...@apache.org>
> >> wrote:
> >>>>
> >>>>> Hello Ignite devs,
> >>>>>
> >>>>> Please, take a look at the proposal for Ignite3
> >>>>>
> >>>>>
> >>>>>
> >>
> https://cwiki.apache.org/confluence/display/IGNITE/IEP-130%3A+Spring+Boot+support
> >>>>>
> >>>>> --
> >>>>> Maksim Myskov
> >>>>>
> >>>>>
> >>>
> >>
> >>
>
>
Re: [DISCUSSION] IEP-130: Spring Boot support
Posted by Maxim Myskov <ma...@gmail.com>.
Yes, it would be easier to manage configs if they could be identical on all nodes. This would avoid situations where several nodes have this flag (in case if it is a flag) enabled.
--
Maksim Myskov
> On 3 Dec 2024, at 17:13, Pavel Tupitsyn <pt...@apache.org> wrote:
>
>> adding the "ignite.bootstrap.nodeName" property to define the node that
> performs cluster initialization on startup
>
> Why node name and not a boolean flag?
> Is that so the config is the same on all nodes, but only the node with the
> matching name starts initialization?
>
> On Tue, Dec 3, 2024 at 3:56 PM Maxim Myskov <ma...@gmail.com> wrote:
>
>> Hello Pavel,
>>
>> What do you think about the approach?
>>
>> --
>> Maksim Myskov
>>
>>> On 28 Nov 2024, at 11:54, Maxim Myskov <ma...@gmail.com> wrote:
>>>
>>> Hello Pavel,
>>>
>>> I updated the "Embedded mode” section, please take a look.
>>> In short, I propose adding the "ignite.bootstrap.nodeName" property to
>> define the node that performs cluster initialization on startup.
>>> I look forward to receiving feedback on this approach.
>>>
>>> --
>>> Maksim Myskov
>>>
>>>> On 22 Nov 2024, at 14:49, Pavel Tupitsyn <pt...@apache.org> wrote:
>>>>
>>>> Hello Maksim,
>>>>
>>>> The proposal looks good in general.
>>>>
>>>> I think we need more details on cluster initialization mechanism - who
>>>> calls init and when? What if there are multiple Spring-based embedded
>> nodes?
>>>>
>>>> On Fri, Nov 22, 2024 at 1:36 PM Maksim Myskov <my...@apache.org>
>> wrote:
>>>>
>>>>> Hello Ignite devs,
>>>>>
>>>>> Please, take a look at the proposal for Ignite3
>>>>>
>>>>>
>>>>>
>> https://cwiki.apache.org/confluence/display/IGNITE/IEP-130%3A+Spring+Boot+support
>>>>>
>>>>> --
>>>>> Maksim Myskov
>>>>>
>>>>>
>>>
>>
>>
Re: [DISCUSSION] IEP-130: Spring Boot support
Posted by Pavel Tupitsyn <pt...@apache.org>.
> adding the "ignite.bootstrap.nodeName" property to define the node that
performs cluster initialization on startup
Why node name and not a boolean flag?
Is that so the config is the same on all nodes, but only the node with the
matching name starts initialization?
On Tue, Dec 3, 2024 at 3:56 PM Maxim Myskov <ma...@gmail.com> wrote:
> Hello Pavel,
>
> What do you think about the approach?
>
> --
> Maksim Myskov
>
> > On 28 Nov 2024, at 11:54, Maxim Myskov <ma...@gmail.com> wrote:
> >
> > Hello Pavel,
> >
> > I updated the "Embedded mode” section, please take a look.
> > In short, I propose adding the "ignite.bootstrap.nodeName" property to
> define the node that performs cluster initialization on startup.
> > I look forward to receiving feedback on this approach.
> >
> > --
> > Maksim Myskov
> >
> >> On 22 Nov 2024, at 14:49, Pavel Tupitsyn <pt...@apache.org> wrote:
> >>
> >> Hello Maksim,
> >>
> >> The proposal looks good in general.
> >>
> >> I think we need more details on cluster initialization mechanism - who
> >> calls init and when? What if there are multiple Spring-based embedded
> nodes?
> >>
> >> On Fri, Nov 22, 2024 at 1:36 PM Maksim Myskov <my...@apache.org>
> wrote:
> >>
> >>> Hello Ignite devs,
> >>>
> >>> Please, take a look at the proposal for Ignite3
> >>>
> >>>
> >>>
> https://cwiki.apache.org/confluence/display/IGNITE/IEP-130%3A+Spring+Boot+support
> >>>
> >>> --
> >>> Maksim Myskov
> >>>
> >>>
> >
>
>
Re: [DISCUSSION] IEP-130: Spring Boot support
Posted by Maxim Myskov <ma...@gmail.com>.
Hello Pavel,
What do you think about the approach?
--
Maksim Myskov
> On 28 Nov 2024, at 11:54, Maxim Myskov <ma...@gmail.com> wrote:
>
> Hello Pavel,
>
> I updated the "Embedded mode” section, please take a look.
> In short, I propose adding the "ignite.bootstrap.nodeName" property to define the node that performs cluster initialization on startup.
> I look forward to receiving feedback on this approach.
>
> --
> Maksim Myskov
>
>> On 22 Nov 2024, at 14:49, Pavel Tupitsyn <pt...@apache.org> wrote:
>>
>> Hello Maksim,
>>
>> The proposal looks good in general.
>>
>> I think we need more details on cluster initialization mechanism - who
>> calls init and when? What if there are multiple Spring-based embedded nodes?
>>
>> On Fri, Nov 22, 2024 at 1:36 PM Maksim Myskov <my...@apache.org> wrote:
>>
>>> Hello Ignite devs,
>>>
>>> Please, take a look at the proposal for Ignite3
>>>
>>>
>>> https://cwiki.apache.org/confluence/display/IGNITE/IEP-130%3A+Spring+Boot+support
>>>
>>> --
>>> Maksim Myskov
>>>
>>>
>
Re: [DISCUSSION] IEP-130: Spring Boot support
Posted by Maxim Myskov <ma...@gmail.com>.
Hello Pavel,
I updated the "Embedded mode” section, please take a look.
In short, I propose adding the "ignite.bootstrap.nodeName" property to define the node that performs cluster initialization on startup.
I look forward to receiving feedback on this approach.
--
Maksim Myskov
> On 22 Nov 2024, at 14:49, Pavel Tupitsyn <pt...@apache.org> wrote:
>
> Hello Maksim,
>
> The proposal looks good in general.
>
> I think we need more details on cluster initialization mechanism - who
> calls init and when? What if there are multiple Spring-based embedded nodes?
>
> On Fri, Nov 22, 2024 at 1:36 PM Maksim Myskov <my...@apache.org> wrote:
>
>> Hello Ignite devs,
>>
>> Please, take a look at the proposal for Ignite3
>>
>>
>> https://cwiki.apache.org/confluence/display/IGNITE/IEP-130%3A+Spring+Boot+support
>>
>> --
>> Maksim Myskov
>>
>>
Re: [DISCUSSION] IEP-130: Spring Boot support
Posted by Pavel Tupitsyn <pt...@apache.org>.
Hello Maksim,
The proposal looks good in general.
I think we need more details on cluster initialization mechanism - who
calls init and when? What if there are multiple Spring-based embedded nodes?
On Fri, Nov 22, 2024 at 1:36 PM Maksim Myskov <my...@apache.org> wrote:
> Hello Ignite devs,
>
> Please, take a look at the proposal for Ignite3
>
>
> https://cwiki.apache.org/confluence/display/IGNITE/IEP-130%3A+Spring+Boot+support
>
> --
> Maksim Myskov
>
>