[jira] [Commented] (FLINK-13385) Align Hive data type mapping with FLIP-37

["Xuefu Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-13385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891444#comment-16891444 ] 

Xuefu Zhang commented on FLINK-13385:
-------------------------------------

Hi [~twalthr], thanks for pointing this out. I'm not sure if I fully understand your change request regarding the following:
{code}
BINARY	>>N/A<<
VARBINARY(p)	>>N/A<<
>>BYTES		BINARY<<
{code}

The first two lines are currently mapped to Hive binary type, as shown in HiveTypeUtil.java. In addition, BINARY and VARBINARY are defined in LogicalTypeRoot while BYTES are defined in DataTypes. I'm not sure why we should put them together.

Please clarify.

> Align Hive data type mapping with FLIP-37
> -----------------------------------------
>
>                 Key: FLINK-13385
>                 URL: https://issues.apache.org/jira/browse/FLINK-13385
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Hive
>            Reporter: Timo Walther
>            Priority: Major
>
> By looking at the Hive data type mapping of:
> https://ci.apache.org/projects/flink/flink-docs-master/dev/table/catalog.html#data-type-mapping
> Based on the information available in:
> https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types
> It seems that the type are not mapped correctly. The following changes should be performed (indicated by {{>>...<<}}):
> {code}
> CHAR(p)	char(p)*
> VARCHAR(p)	varchar(p)**
> STRING	string
> BOOLEAN	boolean
> >>TINYINT<<	tinyint
> >>SMALLINT<<	smallint
> INT	int
> BIGINT	long
> FLOAT	float
> DOUBLE	double
> DECIMAL(p, s)	decimal(p, s)
> DATE	date
> TIMESTAMP_WITHOUT_TIME_ZONE	TIMESTAMP
> TIMESTAMP_WITH_TIME_ZONE	N/A
> TIMESTAMP_WITH_LOCAL_TIME_ZONE	N/A
> INTERVAL	>>INTERVAL?<<
> BINARY	>>N/A<<
> VARBINARY(p)	>>N/A<<
> >>BYTES		BINARY<<
> >>ARRAY<E>	ARRAY<E><<
> >>MAP<K, V>	MAP<K, V>* we support more than primitives<<
> ROW	struct
> MULTISET	N/A
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)