You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/11/21 01:29:41 UTC
[GitHub] [druid] gianm opened a new pull request, #13393: MSQ: Launch initial tasks faster.
gianm opened a new pull request, #13393:
URL: https://github.com/apache/druid/pull/13393
Notify the mainLoop thread to skip a sleep when the desired task count changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on a diff in pull request #13393: MSQ: Launch initial tasks faster.
Posted by GitBox <gi...@apache.org>.
gianm commented on code in PR #13393:
URL: https://github.com/apache/druid/pull/13393#discussion_r1027634116
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTaskLauncher.java:
##########
@@ -460,7 +467,9 @@ private void sleep(final long sleepMillis, final boolean shuttingDown) throws In
} else {
// wait on taskIds so we can wake up early if needed.
synchronized (taskIds) {
- taskIds.wait(sleepMillis);
+ if (acknowledgedDesiredTaskCount == desiredTaskCount) {
Review Comment:
OK, added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz merged pull request #13393: MSQ: Launch initial tasks faster.
Posted by GitBox <gi...@apache.org>.
kfaraz merged PR #13393:
URL: https://github.com/apache/druid/pull/13393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on a diff in pull request #13393: MSQ: Launch initial tasks faster.
Posted by GitBox <gi...@apache.org>.
cryptoe commented on code in PR #13393:
URL: https://github.com/apache/druid/pull/13393#discussion_r1027509271
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTaskLauncher.java:
##########
@@ -460,7 +467,9 @@ private void sleep(final long sleepMillis, final boolean shuttingDown) throws In
} else {
// wait on taskIds so we can wake up early if needed.
synchronized (taskIds) {
- taskIds.wait(sleepMillis);
+ if (acknowledgedDesiredTaskCount == desiredTaskCount) {
Review Comment:
Nit: Can we add a note here. Something like :
As desiredTaskCount can change in `launchTasksIfNeeded` which can be called externally from any thread, we need to way to wake up the main loop in case desiredTaskCount is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org