You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "FrankChen021 (via GitHub)" <gi...@apache.org> on 2026/09/01 15:04:38 UTC

[PR] test: migrate ExecutorLifecycleTest to JUnit 5 (druid)

FrankChen021 opened a new pull request, #20223:
URL: https://github.com/apache/druid/pull/20223

   ### Description
   
   The current `master` build fails during test compilation because `ExecutorLifecycleTest` imports JUnit 4 classes even though the JUnit 4 dependencies were removed as part of the JUnit 5 migration.
   
   This change migrates the test to JUnit 5 by using `org.junit.jupiter.api.Test` and `org.junit.jupiter.api.Assertions`, preserving the existing test behavior.
   
   #### Release note
   
   No release note is needed; this is a test-only CI fix.
   
   <hr>
   
   ##### Key changed/added classes in this PR
   
    * `ExecutorLifecycleTest`
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in `licenses.yaml`
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] added or updated unit tests to cover the affected code path.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   
   ### Verification
   
   `mvn -ntp test -pl indexing-service -am -Dtest=org.apache.druid.indexing.worker.executor.ExecutorLifecycleTest -Dsurefire.failIfNoSpecifiedTests=false -Pskip-static-checks -Dweb.console.skip=true -T1C`
   
   Result: 2 tests run, 0 failures, 0 errors.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

Re: [PR] fix: restore master CI (druid)

Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 merged PR #20223:
URL: https://github.com/apache/druid/pull/20223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org