You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hongyuan Li (JIRA)" <ji...@apache.org> on 2017/05/31 16:02:04 UTC
[jira] [Updated] (HADOOP-14470) the ternary operator in create
method in class CommandWithDestination is redundant
[ https://issues.apache.org/jira/browse/HADOOP-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hongyuan Li updated HADOOP-14470:
---------------------------------
Issue Type: Improvement (was: Bug)
> the ternary operator in create method in class CommandWithDestination is redundant
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-14470
> URL: https://issues.apache.org/jira/browse/HADOOP-14470
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Hongyuan Li
> Assignee: Hongyuan Li
> Priority: Trivial
>
> in if statement，the lazyPersist is always true, thus the ternary operator is redundant，related code like below:
> {code}
> FSDataOutputStream create(PathData item, boolean lazyPersist,
> boolean direct)
> throws IOException {
> try {
> if (lazyPersist) {
> ……
> return create(item.path,
> FsPermission.getFileDefault().applyUMask(
> FsPermission.getUMask(getConf())),
> createFlags,
> getConf().getInt(IO_FILE_BUFFER_SIZE_KEY,
> IO_FILE_BUFFER_SIZE_DEFAULT),
> lazyPersist ? 1 : getDefaultReplication(item.path), // this is redundant
> getDefaultBlockSize(),
> null,
> null);
> } else {
> return create(item.path, true);
> }
> } finally { // might have been created but stream was interrupted
> if (!direct) {
> deleteOnExit(item.path);
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org