You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/10/16 20:35:36 UTC

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21943


Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................

[dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED

This patch adds SKIP_IF_SLOW_NOT_ALLOWED() macro into appropriate
scenarios in the dynamic_multi_master-test.  The criteria to tag a
scenario as 'slow' was the evidence of requiring more than 3 seconds
to complete on a more-or-less contemporary machine (DEBUG build).

The motivation for this changelist is to address the review feedback
for one of the prior patches [1].

[1] http://gerrit.cloudera.org:8080/21935

Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
---
M src/kudu/master/dynamic_multi_master-test.cc
1 file changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/21943/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21943 )

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/600/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2024 21:35:48 +0000
Gerrit-HasComments: No

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21943 )

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 18 Oct 2024 08:41:11 +0000
Gerrit-HasComments: No

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Abhishek Chennaka, KeDeng, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21943

to look at the new patch set (#2).

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................

[dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED

This patch adds SKIP_IF_SLOW_NOT_ALLOWED() macro into appropriate
scenarios in the dynamic_multi_master-test.  The criteria to tag a
scenario as 'slow' was the evidence of requiring more than 3 seconds
to complete on a more-or-less contemporary machine (DEBUG build).

The motivation for this changelist is to address the review feedback
for one of the prior patches [1].

[1] review URL: http://gerrit.cloudera.org:8080/21935
    gerrit ID : Id0f0005b8f3384ad05eee6bf65e17a0e4ed289f1
    git hash  : dbb6d5320ad60016355d0c63b6dae1650ba4e414

Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
---
M src/kudu/master/dynamic_multi_master-test.cc
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/21943/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21943 )

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/594/


-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Oct 2024 20:35:41 +0000
Gerrit-HasComments: No

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21943 )

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21943/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21943/1//COMMIT_MSG@15
PS1, Line 15: for one of the prior patches [1].
> can you add the change-id or the commit message instead so it is more self-
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2024 19:23:46 +0000
Gerrit-HasComments: Yes

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21943 )

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................


Patch Set 2: Verified+1

unrelated CI pipeline and test failures:
  * RELEASE: Could not submit Java distributed test job
  * TSAN: auto_leader_rebalancer-test, predicate-test, alter_table-test.


-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Oct 2024 00:36:34 +0000
Gerrit-HasComments: No

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21943 )

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21943/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21943/1//COMMIT_MSG@15
PS1, Line 15: for one of the prior patches [1].
can you add the change-id or the commit message instead so it is more self-contained?



-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2024 06:35:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21943 )

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................


Patch Set 1: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/594/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Oct 2024 21:33:07 +0000
Gerrit-HasComments: No

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21943 )

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/600/


-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2024 19:23:36 +0000
Gerrit-HasComments: No

[kudu-CR] [dynamic multi master-test] add SKIP IF SLOW NOT ALLOWED

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21943 )

Change subject: [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED
......................................................................

[dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED

This patch adds SKIP_IF_SLOW_NOT_ALLOWED() macro into appropriate
scenarios in the dynamic_multi_master-test.  The criteria to tag a
scenario as 'slow' was the evidence of requiring more than 3 seconds
to complete on a more-or-less contemporary machine (DEBUG build).

The motivation for this changelist is to address the review feedback
for one of the prior patches [1].

[1] review URL: http://gerrit.cloudera.org:8080/21935
    gerrit ID : Id0f0005b8f3384ad05eee6bf65e17a0e4ed289f1
    git hash  : dbb6d5320ad60016355d0c63b6dae1650ba4e414

Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Reviewed-on: http://gerrit.cloudera.org:8080/21943
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/master/dynamic_multi_master-test.cc
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Marton Greber: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/21943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>