[jira] [Commented] (HBASE-10046) Unmonitored HBase service could accumulate Status objects and OOM

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833433#comment-13833433 ] 

Hadoop QA commented on HBASE-10046:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12615968/HBASE-10046.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8013//console

This message is automatically generated.

> Unmonitored HBase service could accumulate Status objects and OOM
> -----------------------------------------------------------------
>
>                 Key: HBASE-10046
>                 URL: https://issues.apache.org/jira/browse/HBASE-10046
>             Project: HBase
>          Issue Type: Bug
>          Components: monitoring
>    Affects Versions: 0.96.0, 0.94.14
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>         Attachments: HBASE-10046.patch, HBASE-10046_0.94.patch
>
>
> This was observed in a cluster where HBase Master UI was not monitored for quite a while. During this period, a distributed log spitting task failed in an in-completable way and Master kept recreating the task over and over again.
> And each such task would create a monitored status...
> {code:title=SplitLogManager.java}
> .......
>   public long splitLogDistributed(final List<Path> logDirs, PathFilter filter) 
>       throws IOException {
>     MonitoredTask status = TaskMonitor.get().createStatus(
>           "Doing distributed log split in " + logDirs);
> .......
> {code}
> ...which kept accumulating on heap.
> Now these monitored tasks get cleaned only when someone looks at the service UI otherwise they keep growing boundless.
> The postmortem of the heap dump showed that these task object occupied 99% of HBase master heap accumulated over a week.



--
This message was sent by Atlassian JIRA
(v6.1#6144)