You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2020/09/16 07:28:12 UTC
[GitHub] [incubator-pegasus] neverchanje opened a new pull request #602: build: remove restrict to build from non-git-repo
neverchanje opened a new pull request #602:
URL: https://github.com/apache/incubator-pegasus/pull/602
### What problem does this PR solve? <!--add issue link with summary if exists-->
### What is changed and how it works?
### Check List <!--REMOVE the items that are not applicable-->
Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje commented on pull request #602: build: remove restrict to build from non-git-repo
Posted by GitBox <gi...@apache.org>.
neverchanje commented on pull request #602:
URL: https://github.com/apache/incubator-pegasus/pull/602#issuecomment-693766344
`PEGASUS_GIT_COMMIT` is a complement of `PEGASUS_VERSION` (src/include/pegasus/version.h), in my opinion. So I just keep consistent with what it is in non-git repo. But truth is, I agree that `PEGASUS_GIT_COMMIT` has no much use.
`PEGASUS_GIT_COMMIT` is not "generated" from the downloaded source. It exists in the source package as the `GIT_COMMIT` file which is provided by who produced the package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #602: build: remove restrict to build from non-git-repo
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #602:
URL: https://github.com/apache/incubator-pegasus/pull/602#issuecomment-693555393
What’s the benefit of generating a commit Id when build from non-git-repo? When we release a .tar package, the branch/tag is filled in a version file, I think it is enough to describe what version user use.
On the other hand, how this GIT_COMMIT file update if cherry-pick more patches to the release branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje merged pull request #602: build: remove restrict to build from non-git-repo
Posted by GitBox <gi...@apache.org>.
neverchanje merged pull request #602:
URL: https://github.com/apache/incubator-pegasus/pull/602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje edited a comment on pull request #602: build: remove restrict to build from non-git-repo
Posted by GitBox <gi...@apache.org>.
neverchanje edited a comment on pull request #602:
URL: https://github.com/apache/incubator-pegasus/pull/602#issuecomment-693766344
`PEGASUS_GIT_COMMIT` is a complement of `PEGASUS_VERSION` (src/include/pegasus/version.h), in my opinion. So I just keep consistent with what it is in non-git repo. But truth is, I agree that `PEGASUS_GIT_COMMIT` has no much use.
`PEGASUS_GIT_COMMIT` is not "generated" from the downloaded source. It exists in the source package as the `GIT_COMMIT` file which is provided by who produced the package, via `bump_version.sh`.
So when you cherry-pick to the release branch, it won't be updated. It updates when you call `bump_version.sh`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org