You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/01/05 20:55:03 UTC

[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #15: Remove pekko prefix from modules

mdedetrich commented on PR #15:
URL: https://github.com/apache/incubator-pekko-http/pull/15#issuecomment-1372734963

   > should we also remove the `http` prefix? Since the `pekko-http` prefix is implied, then don't we want `core` instead of `http-core`, `caching` instead of `http-caching`, etc.? In your current change it looks like we're doing this already with `bill-of-materials` and `parsing`.
   
   For me the redundant part is the root project (i.e. `pekko`), not what the project is implementing. The changes to `bill-of-materials` was done just to make it consistent with pekko core and the change to `parsing` wasn't exceptional in any way (it was `pekko-parsing` before, not `pekko-http-parsing`.
   
   While I think I understand the sentiment I believe this is going too far, most importantly since there is a relation of the name to the published artifact if we hypothetically rename `http-core` to `core` (for example), the artifact still needs to be called `pekko-http-core` and not `pekko-core` (because otherwise it can conflict with other pekko repos under the same `org.apache.pekko`). Even the current proposed changes is stretching it a bit for current committers and to me what is making it acceptable is that at least for the modules that create artifacts (which `bill-of-materials`/`root`/`docs` are not) there is a logical relation/computation to the artifact


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org