[GitHub] [hop] hansva commented on pull request #2229: #2115 Unable to stop hop-server from command-line

["hansva (via GitHub)" <gi...@apache.org>]

hansva commented on PR #2229:
URL: https://github.com/apache/hop/pull/2229#issuecomment-1425722559

   Seems to work as expected, thanks @uraychang ! I only have a couple of small remarks.
   
   Remarks:
   - when executing `./hop-server.sh -k -u cluster -p cluster localhost 8079` we now get a stacktrace [1] I think we need to send a response before actually killing it something like "stopping server on port ...."
   - we provide a default hop-server.xml maybe we should add the option in there by default too `assemblies/static/src/main/resources/hop-server.xml`
   - Documentation needs an update
   - Docker documentation needs an update (exposing the port too)
   
   [1]
   ```
   eb 10, 2023 1:00:35 PM org.glassfish.jersey.message.internal.MessagingBinders$EnabledProvidersBinder bindToBinder
   WARNING: A class javax.activation.DataSource for a default provider MessageBodyWriter<javax.activation.DataSource> was not found. The provider is not available.
   org.apache.hop.www.HopServer$HopServerCommandException: "No Hop Server Server found at localhost:8079
   	at org.apache.hop.www.HopServer.callStopHopServerRestService(HopServer.java:695)
   	at org.apache.hop.www.HopServer.shutdown(HopServer.java:644)
   	at org.apache.hop.www.HopServer.run(HopServer.java:278)
   	at org.apache.hop.www.HopServer.main(HopServer.java:564)
   Caused by: javax.ws.rs.ProcessingException: java.net.ConnectException: Connection refused
   	at org.glassfish.jersey.client.internal.HttpUrlConnector.apply(HttpUrlConnector.java:268)
   	at org.glassfish.jersey.client.ClientRuntime.invoke(ClientRuntime.java:297)
   	at org.glassfish.jersey.client.JerseyInvocation.lambda$invoke$1(JerseyInvocation.java:675)
   	at org.glassfish.jersey.client.JerseyInvocation.call(JerseyInvocation.java:697)
   	at org.glassfish.jersey.client.JerseyInvocation.lambda$runInScope$3(JerseyInvocation.java:691)
   	at org.glassfish.jersey.internal.Errors.process(Errors.java:292)
   	at org.glassfish.jersey.internal.Errors.process(Errors.java:274)
   	at org.glassfish.jersey.internal.Errors.process(Errors.java:205)
   	at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:390)
   	at org.glassfish.jersey.client.JerseyInvocation.runInScope(JerseyInvocation.java:691)
   	at org.glassfish.jersey.client.JerseyInvocation.invoke(JerseyInvocation.java:674)
   	at org.glassfish.jersey.client.JerseyInvocation$Builder.method(JerseyInvocation.java:422)
   	at org.glassfish.jersey.client.JerseyInvocation$Builder.get(JerseyInvocation.java:318)
   	at org.apache.hop.www.HopServer.callStopHopServerRestService(HopServer.java:681)
   	... 3 more
   Caused by: java.net.ConnectException: Connection refused
   	at java.base/sun.nio.ch.Net.connect0(Native Method)
   	at java.base/sun.nio.ch.Net.connect(Net.java:579)
   	at java.base/sun.nio.ch.Net.connect(Net.java:568)
   	at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:576)
   	at java.base/java.net.Socket.connect(Socket.java:666)
   	at java.base/sun.net.NetworkClient.doConnect(NetworkClient.java:178)
   	at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:531)
   	at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:636)
   	at java.base/sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:932)
   	at java.base/sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:759)
   	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1684)
   	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1585)
   	at java.base/java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:529)
   	at org.glassfish.jersey.client.internal.HttpUrlConnector._apply(HttpUrlConnector.java:377)
   	at org.glassfish.jersey.client.internal.HttpUrlConnector.apply(HttpUrlConnector.java:266)
   	... 16 more
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org