You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 01:01:58 UTC
Review Request 70098: Made cpplint.patch reflect our modifications.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70098/
-----------------------------------------------------------
Review request for mesos and Armand Grillet.
Repository: mesos
Description
-------
This patch was created by performing a `git diff` of our current
version agains our upstream version `43d512ba130`.
Diffs
-----
support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7
Diff: https://reviews.apache.org/r/70098/diff/1/
Testing
-------
N/A
Thanks,
Benjamin Bannier
Re: Review Request 70098: Removed `support/cpplint.patch`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70098/#review213514
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70098/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 1:01 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change removes explicit tracking of a patch against upstream
> cpplint in the tree and replaces it with a clear reference against the
> upstream repository and revision used in the modified file.
>
> The patch was never used by us against any upstream version, and was
> not e.g., a legal requirement. The process around creating the patch
> was cumbersome and error prone. Removing the patch from the tree
> should not only make it easier to evolve our modifications going
> forward, but also remove a lot of noise from changes.
>
>
> Diffs
> -----
>
> support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7
> support/cpplint.py d3e7aaf71255cf4efd0239434f7630afd6ea47d0
>
>
> Diff: https://reviews.apache.org/r/70098/diff/2/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70098: Made cpplint.patch reflect our
modifications.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70098/#review213470
-----------------------------------------------------------
Looking at this deeper, I'm not sure we should explicitly maintain the patch. Of course, ideally we would have a copy of a specific version of cpplint plus the patch, but it is unclear when to apply the patch (on bootstrap? on build?). To make things simpler and have only one source of truth, let's **remove** the patch altogether and leave a comment in the **modified** version of `cpplint.py` with 1) SHA of the base `cpplint.py` to be able to restore the diff and 2) a quick overview of our modifications.
support/cpplint.patch
Lines 1-4 (original), 1-4 (patched)
<https://reviews.apache.org/r/70098/#comment299402>
These are not whitespace changes : )
- Alexander Rukletsov
On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70098/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 1:01 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch was created by performing a `git diff` of our current
> version agains our upstream version `43d512ba130`.
>
> This patch restores trailing but significant whitespaces to the patch
> file, which are flagged by our commit hooks. When committing we need to
> skip these hooks.
>
>
> Diffs
> -----
>
> support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7
>
>
> Diff: https://reviews.apache.org/r/70098/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70098: Made cpplint.patch reflect our
modifications.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70098/#review213482
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70098/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 1:01 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch was created by performing a `git diff` of our current
> version agains our upstream version `43d512ba130`.
>
> This patch restores trailing but significant whitespaces to the patch
> file, which are flagged by our commit hooks. When committing we need to
> skip these hooks.
>
>
> Diffs
> -----
>
> support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7
>
>
> Diff: https://reviews.apache.org/r/70098/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Bannier
>
>